Use IsTerminal instead of OutputIsRedirected #2248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RELEASE_NOTES=[CLEANUP] Deprecate OutputIsRedirected in favour of IsTerminal Fixes #2025 Signed-off-by: Yolan Romailler <[email protected]>
dominikschulz
requested changes
May 31, 2022
Signed-off-by: Yolan Romailler <[email protected]>
|
Yup, sorry for that, I had Go 1.17.9 installed locally with golangci-lint 1.45 so couldn't run it locally, and then really wanted to go to bed yesterday evening 😅 |
|
The Linux build golangci-lint issue is fixed in #2245. |
AnomalRoil
changed the title
Merged
kpitt
pushed a commit
to kpitt/gopass
that referenced
this pull request
Jul 21, 2022
* Use IsTermninal instead of OutputIsRedirected RELEASE_NOTES=[CLEANUP] Deprecate OutputIsRedirected in favour of IsTerminal Fixes gopasspw#2025 Signed-off-by: Yolan Romailler <[email protected]> * Fix lint Signed-off-by: Yolan Romailler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate
out.OutputIsRedirectedin favour of!ctxutil.IsTerminal.Fixes #2025.