-
Notifications
You must be signed in to change notification settings - Fork 69
chore: add configuration for protobuf-4.x-rc branch #3997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @diegomarquezp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
The validation error is not about this branch entry: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds configuration for the protobuf-4.x-rc branch to the .github/release-please.yml file. The configuration seems mostly correct, but I've identified a potential inconsistency in the releaseType that could impact how release pull requests are generated for this branch. My feedback includes a suggestion to align the configuration with the mono-repo setup indicated in release-please-config.json.
| bumpMinorPreMajor: true | ||
| handleGHRelease: true | ||
| manifest: true | ||
| releaseType: java-yoshi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be an inconsistency between the releaseType specified here (java-yoshi) and the release-type in release-please-config.json (java-yoshi-mono-repo). Using the java-yoshi type might cause release-please to overlook mono-repo-specific settings defined in release-please-config.json, such as group-pull-request-title-pattern. This could lead to incorrectly formatted release pull requests. To ensure the mono-repo configuration is fully respected, consider aligning the release type.
releaseType: java-yoshi-mono-repo
|
|



Branch configured already. See https://github.com/googleapis/sdk-platform-java/blob/protobuf-4.x-rc/release-please-config.json