refactor: create base transaction class #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
BenWhitehead
approved these changes
Jul 6, 2020
Collaborator
BenWhitehead
left a comment
BenWhitehead
left a comment
There was a problem hiding this comment.
Seems inline with what we've been talking about. Deferring to @crwilcox for code specifics.
Contributor
|
This lgtm. Let's hold though until the big merge in #91 |
rafilong
force-pushed
the
refactor-transaction
branch
from
b5d54c5 to
bd51726
Compare
crwilcox
approved these changes
Jul 14, 2020
rafilong
added
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
towards #65