doc(samples): use operation to ensure creation completed #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to showing the better practice (using the operation returned from 'Instance.create' / 'Cluster.create'), this change also hardens the sample against eventual-consistency issues. The timeouts used match those used in the system tests. Closes #353.
product-auto-label
bot
added
api: bigtable
google-cla
bot
added
the
cla: yes
kolea2
approved these changes
Jul 9, 2021
Collaborator
kolea2
left a comment
kolea2
left a comment
There was a problem hiding this comment.
LGTM after typo fix. Thanks for taking a look at this!
tseaver
added
the
automerge
kolea2
removed
the
automerge
Collaborator
|
@tseaver looks like the samples failed, maybe some unrelated flakiness? edit: nvm, maybe we should increase the timeouts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to showing the better practice (using the operation returned
from 'Instance.create' / 'Cluster.create'), this change also hardens
the sample against eventual-consistency issues.
Closes #353.