Skip to content

Use shim for legacy client sample_row_keys #1167

@daniel-sanche

Description

@daniel-sanche

The legacy client exposes sample_row_keys as a method on the Table class. This should be simple to swap out for the veneer substitute

The one complication should be the return types; the legacy client seems to return the gapic response directly, while the veneer client unpacks it into a tuple list (with a type alias of RowKeySamples). We could re-build the proto object to keep things consistent, or possibly change the return type as a breaking change. Depends on what we see about typical usage

Metadata

Metadata

Assignees

Labels

api: bigtableIssues related to the googleapis/python-bigtable API.priority: p3Desirable enhancement or fix. May not be included in next release.samplesIssues that are directly related to samples.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions