Skip to content

fix: no longer set autodetect=True with empty schema in load_table_from_json() #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Linchin wants to merge 3 commits into from
Closed

fix: no longer set autodetect=True with empty schema in load_table_from_json() #1801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81d3530
fix: not force autodetect=true for absent schema with load json
Linchin Jan 25, 2024
70b5c85
Merge branch 'main' into autodetect
Linchin Jan 25, 2024
48e3645
fix unit test
Linchin Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions google/cloud/bigquery/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2833,9 +2833,6 @@ def load_table_from_json(

new_job_config.source_format = job.SourceFormat.NEWLINE_DELIMITED_JSON

if new_job_config.schema is None:
Copy link
Contributor

@tswast tswast Jan 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are still getting test failures with this change:


>           raise exceptions.from_http_response(exc.response)
E           google.api_core.exceptions.BadRequest: 400 POST https://bigquery.googleapis.com/upload/bigquery/v2/projects/precise-truck-742/jobs?uploadType=multipart: No schema specified on job or table.

I think we can only omit these if the table already exists and we are appending rows.

Copy link
Contributor Author

@Linchin Linchin Jan 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think I made a mistake in my test code and created the table with schema in it.

new_job_config.autodetect = True

if project is None:
project = self.project

Expand Down
2 changes: 1 addition & 1 deletion tests/unit/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8986,7 +8986,7 @@ def test_load_table_from_json_basic_use(self):
sent_config = load_table_from_file.mock_calls[0][2]["job_config"]
assert sent_config.source_format == job.SourceFormat.NEWLINE_DELIMITED_JSON
assert sent_config.schema is None
assert sent_config.autodetect
assert sent_config.autodetect is None

def test_load_table_from_json_non_default_args(self):
from google.cloud.bigquery import job
Expand Down