Skip to content

fix: raise most recent exception when not able to fetch query job after starting the job #1362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chalmerlowe merged 6 commits into from
Jun 1, 2023
Merged

fix: raise most recent exception when not able to fetch query job after starting the job #1362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ce7d358
fix: raise most recent exception when not able to fetch query job aft…
tswast Sep 20, 2022
a151866
Merge branch 'main' into tswast-b247809965
tswast May 24, 2023
0c8ae0d
update unit test
tswast May 24, 2023
6870377
Merge branch 'main' into tswast-b247809965
tswast May 31, 2023
8b428b5
revert most changes to the test and explain why we're looking for a d…
tswast Jun 1, 2023
8a257bb
Merge branch 'main' into tswast-b247809965
tswast Jun 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion google/cloud/bigquery/_job_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ def do_query():
timeout=timeout,
)
except core_exceptions.GoogleAPIError: # (includes RetryError)
raise create_exc
raise
else:
return query_job
else:
Expand Down
8 changes: 5 additions & 3 deletions tests/unit/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5092,12 +5092,14 @@ def test_query_job_rpc_fail_w_conflict_random_id_job_fetch_fails(self):
QueryJob, "_begin", side_effect=job_create_error
)
get_job_patcher = mock.patch.object(
client, "get_job", side_effect=DataLoss("we lost yor job, sorry")
client, "get_job", side_effect=DataLoss("we lost your job, sorry")
)

with job_begin_patcher, get_job_patcher:
# If get job request fails, the original exception should be raised.
with pytest.raises(Conflict, match="Job already exists."):
# If get job request fails but supposedly there does exist a job
# with this ID already, raise the exception explaining why we
# couldn't recover the job.
with pytest.raises(DataLoss, match="we lost your job, sorry"):
client.query("SELECT 1;", job_id=None)

def test_query_job_rpc_fail_w_conflict_random_id_job_fetch_succeeds(self):
Expand Down