chore!: migrate to Node 18 #2399
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: This pull request is touching the following templated files:
|
product-auto-label
bot
added
the
api: firestore
MarkDuckworth
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
sofisl
reviewed
Aug 4, 2025
Update to latest image
* I will fix the floating promise errors. This PR fixes all the floating promise errors in the test files. It also converts all the `then` calls to `async/await` in the test files. * remove jules txt output files * Fix hanging promise errors * Attempting CI fix of tests * Change solution to floating promises where adding await previously changed the meaning of the test. * revert void assert.rejects changes in gapic_firestore_v1beta1.ts tests * Address PR comments --------- Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
sofisl
previously approved these changes
Aug 27, 2025
|
Approved! I think your tests are failing because you don't have a Node 18 kokoro file (this might be because it's excluded in the owlbot.py file). It should mostly just comprise of renaming the kokoro 14 files to 18 (and making sure they're using 18 as the image, node version, etc.). |
MarkDuckworth
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
ehsannas
approved these changes
Sep 22, 2025
| // This list is based on https://github.com/firebase/firebase-js-sdk/blob/master/packages/firestore/src/core/transaction_runner.ts#L112 | ||
| switch (error.code as number) { | ||
| case StatusCode.ABORTED: | ||
| case 409: // GAXIOS may now return HTTP 409 instead of Aborted |
There was a problem hiding this comment.
So weird to see a 409 in the middle of the StatusCodes :)
There was a problem hiding this comment.
At least I expected the formatter to move it before (or after) all other case statements.
| options?: gax.CallOptions | ||
| ): AsyncIterable<protos.google.longrunning.ListOperationsResponse> { | ||
| options?: gax.CallOptions, | ||
| ): AsyncIterable<protos.google.longrunning.IOperation> { |
There was a problem hiding this comment.
Not sure why this changed. The proto still returns a ListOperationsResponse
| @@ -1,1714 +0,0 @@ | |||
| ## API Report File for "@google-cloud/firestore" | |||
There was a problem hiding this comment.
what was the reason for removing firestore.api.md?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes b/397525375. Uses steps defined in b/397525375.