-
Notifications
You must be signed in to change notification settings - Fork 29
fix: clean should preserve and remove files from sourceRoots #1950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
82881b4
to
b1d7164
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1950 +/- ##
==========================================
+ Coverage 82.01% 82.08% +0.06%
==========================================
Files 83 83
Lines 8793 8825 +32
==========================================
+ Hits 7212 7244 +32
- Misses 1231 1232 +1
+ Partials 350 349 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
121ed43
to
3a122f9
Compare
Sorry! My commit bf68599 made the conflict here. |
16dcbdb
to
3385812
Compare
No worries. I was able to resolve the merge conflicts. Thanks for the heads up :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, left comments on testing coverage.
94dc69d
to
72551b3
Compare
Error:
|
6f0b949
to
148e3bd
Compare
Fixes: #1860