Skip to content

Conversation

lqiu96
Copy link
Member

@lqiu96 lqiu96 commented Sep 5, 2025

Fixes: #1860

@lqiu96 lqiu96 force-pushed the sources-root-regex branch 4 times, most recently from 82881b4 to b1d7164 Compare September 8, 2025 15:11
Copy link

codecov bot commented Sep 8, 2025

Codecov Report

❌ Patch coverage is 87.80488% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.08%. Comparing base (89524de) to head (148e3bd).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/librarian/command.go 87.80% 8 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1950      +/-   ##
==========================================
+ Coverage   82.01%   82.08%   +0.06%     
==========================================
  Files          83       83              
  Lines        8793     8825      +32     
==========================================
+ Hits         7212     7244      +32     
- Misses       1231     1232       +1     
+ Partials      350      349       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lqiu96 lqiu96 force-pushed the sources-root-regex branch 2 times, most recently from 121ed43 to 3a122f9 Compare September 8, 2025 16:06
@suztomo
Copy link
Member

suztomo commented Sep 8, 2025

Sorry! My commit bf68599 made the conflict here.

@lqiu96 lqiu96 force-pushed the sources-root-regex branch from 16dcbdb to 3385812 Compare September 8, 2025 18:47
@lqiu96 lqiu96 changed the title fix: preserve and remove files from sourcesRoot fix: clean should preserve and remove files from sourceRoots Sep 8, 2025
@lqiu96 lqiu96 requested a review from JoeWang1127 September 8, 2025 21:43
@lqiu96 lqiu96 marked this pull request as ready for review September 8, 2025 21:43
@lqiu96 lqiu96 requested a review from a team as a code owner September 8, 2025 21:43
@lqiu96
Copy link
Member Author

lqiu96 commented Sep 8, 2025

Sorry! My commit bf68599 made the conflict here.

No worries. I was able to resolve the merge conflicts. Thanks for the heads up :)

Copy link
Contributor

@JoeWang1127 JoeWang1127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, left comments on testing coverage.

@lqiu96 lqiu96 enabled auto-merge (squash) September 9, 2025 15:37
@lqiu96 lqiu96 requested a review from JoeWang1127 September 9, 2025 15:37
@lqiu96 lqiu96 disabled auto-merge September 9, 2025 15:38
@lqiu96 lqiu96 force-pushed the sources-root-regex branch from 94dc69d to 72551b3 Compare September 9, 2025 16:19
@lqiu96
Copy link
Member Author

lqiu96 commented Sep 9, 2025

Error:

--- FAIL: TestGoGenerate (1.34s)
    doc_generate_test.go:29: 
    doc_generate_test.go:30: 
    doc_generate_test.go:36: go generate produced a diff, please run `go generate ./...` and commit the changes
    doc_generate_test.go:39: diff:
        diff --git a/internal/librarian/doc.go b/internal/librarian/doc.go
        index b40b00c..18b7e0f 100644
        --- a/internal/librarian/doc.go
        +++ b/internal/librarian/doc.go
        @@ -24,10 +24,9 @@ Usage:
         	librarian <command> [arguments]
         
         The commands are:
        -  generate                   onboards and generates client library code
        -  release                    manages releases of libraries.
        -  version                    prints the version information
        -
         
        +	generate                   onboards and generates client library code
        +	release                    manages releases of libraries.
        +	version                    prints the version information
         */
         package librarian

@lqiu96 lqiu96 force-pushed the sources-root-regex branch from 6f0b949 to 148e3bd Compare September 9, 2025 17:55
@lqiu96 lqiu96 enabled auto-merge (squash) September 9, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

librarian: remove/preserve regex should only touch files within source roots
3 participants