Skip to content

Conversation

zhumin8
Copy link
Contributor

@zhumin8 zhumin8 commented Aug 28, 2025

It is expected behavior to defaults to the source_roots as documented. Adding missed implementation.

// A list of regular expressions for files and directories to remove before copying generated code.
// If not set, this defaults to the `source_roots`.
// A more specific `preserve_regex` takes precedence.
RemoveRegex []string `yaml:"remove_regex" json:"remove_regex"`

Fixes #1739

@zhumin8 zhumin8 requested a review from a team as a code owner August 28, 2025 07:33
@zhumin8 zhumin8 requested a review from jba August 28, 2025 07:33
Copy link

codecov bot commented Aug 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.55%. Comparing base (8f409cc) to head (f9da4c3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1863      +/-   ##
==========================================
+ Coverage   80.53%   80.55%   +0.02%     
==========================================
  Files          75       75              
  Lines        8185     8194       +9     
==========================================
+ Hits         6592     6601       +9     
  Misses       1237     1237              
  Partials      356      356              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zhumin8 zhumin8 requested a review from JoeWang1127 August 28, 2025 07:53
@zhumin8 zhumin8 enabled auto-merge (squash) August 28, 2025 07:53
@zhumin8 zhumin8 merged commit 3d051f8 into main Aug 28, 2025
11 checks passed
@zhumin8 zhumin8 deleted the fix-rm-empty branch August 28, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

librarian: generate error when remove_regex in state.yaml is empty
2 participants