Skip to content

fix(internal/sidekick): hardcode dart as excluded path #1564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2025
Merged

Conversation

julieqiu
Copy link
Member

@julieqiu julieqiu commented Aug 4, 2025

Sidekick currently hardcodes paths that are excluded when running on the google-cloud-rust repo. Change this from generator/ to dart/ since the code moved.

This logic will be refactored in a follow-up PR.

For #1563

Sidekick currently hardcodes paths that are excluded when running on the
google-cloud-rust repo. Change this from generator/ to dart/ since the
code moved.

This logic will be refactored in a follow-up PR.

For #1563
@julieqiu julieqiu requested a review from a team as a code owner August 4, 2025 18:18
@julieqiu julieqiu requested a review from coryan August 4, 2025 18:18
@julieqiu julieqiu enabled auto-merge (squash) August 4, 2025 18:19
Copy link

codecov bot commented Aug 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.25%. Comparing base (7b4437a) to head (0908c90).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1564   +/-   ##
=======================================
  Coverage   82.25%   82.25%           
=======================================
  Files          16       16           
  Lines        1161     1161           
=======================================
  Hits          955      955           
  Misses        156      156           
  Partials       50       50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@julieqiu julieqiu merged commit b601994 into main Aug 4, 2025
9 of 11 checks passed
@julieqiu julieqiu deleted the refreshall branch August 4, 2025 18:20
catchyzheng pushed a commit that referenced this pull request Aug 5, 2025
Sidekick currently hardcodes paths that are excluded when running on the
google-cloud-rust repo. Change this from generator/ to dart/ since the
code moved.

This logic will be refactored in a follow-up PR.

For #1563
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants