Skip to content

Conversation

amanda-tarafa
Copy link
Collaborator

No description provided.

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 14, 2025
@amanda-tarafa
Copy link
Collaborator Author

Locally generated with googleapis/librarian#2573

Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.65%. Comparing base (2e2fc08) to head (c0b1ab8).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3527   +/-   ##
=======================================
  Coverage   95.65%   95.65%           
=======================================
  Files         123      123           
  Lines        4904     4904           
=======================================
  Hits         4691     4691           
  Misses        213      213           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@amanda-tarafa amanda-tarafa force-pushed the oneof-setter-samples branch 2 times, most recently from 1867da5 to 82ee7f0 Compare October 15, 2025 16:47
@amanda-tarafa
Copy link
Collaborator Author

Oh, we have to merge the assert blocks now. The variables declared on the first block are not visible on the second block. I'm on it.

@amanda-tarafa
Copy link
Collaborator Author

Now generated by googleapis/librarian#2582

@amanda-tarafa
Copy link
Collaborator Author

Now generated with googleapis/librarian#2589

@amanda-tarafa
Copy link
Collaborator Author

There's a previous generator change, I'm bringing that one in another PR.

@amanda-tarafa
Copy link
Collaborator Author

After #3547 is merged, we should be able to rebase this and get it to green.

@amanda-tarafa amanda-tarafa marked this pull request as ready for review October 16, 2025 14:22
@amanda-tarafa amanda-tarafa requested a review from a team as a code owner October 16, 2025 14:22
@amanda-tarafa amanda-tarafa merged commit c733399 into googleapis:main Oct 16, 2025
26 checks passed
@amanda-tarafa amanda-tarafa deleted the oneof-setter-samples branch October 16, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants