Skip to content

Conversation

whuffman36
Copy link
Contributor

@whuffman36 whuffman36 commented Sep 3, 2025

The Rust Friction Log gave users a chance to test the onboarding process and give us feedback. This PR addresses the common issues users had.

@whuffman36 whuffman36 self-assigned this Sep 3, 2025
cargo add google-cloud-aiplatform-v1 --no-default-features --features prediction-service
```

If you are using cloud shell (or have limited disk space), you might see a
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{{#include ../samples/src/gemini.rs:prompt-and-image}}
```

Note: These code samples return `crate::Result<()>` for the sake of brevity.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Ok(())
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whuffman36 whuffman36 requested review from coryan and dbolduc September 3, 2025 21:18
@whuffman36 whuffman36 marked this pull request as ready for review September 3, 2025 21:19
@whuffman36 whuffman36 requested a review from a team as a code owner September 3, 2025 21:19
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.29%. Comparing base (1df548b) to head (1ff15a9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3233      +/-   ##
==========================================
- Coverage   96.33%   96.29%   -0.05%     
==========================================
  Files         110      110              
  Lines        4453     4483      +30     
==========================================
+ Hits         4290     4317      +27     
- Misses        163      166       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment on lines 140 to 144
Note: These code samples return `crate::Result<()>` for the sake of brevity. You
will need to change the return type to
`std::result::Result<(), Box<dyn std::error::Error>>` since your project
structure is likely different from that of the samples.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... projects may use anyhow::Result<()> or the Box thing ... or their own error that wraps our error as a source.

Maybe we should change all the code to use anyhow::Result<()>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah that's convenient, I replaced the crate::Result<()> with anyhow::Result<()>

Comment on lines 37 to 49
If you are using cloud shell (or have limited disk space), you might see a "no
space left on device" error. Run the following to remove build artifacts:

```shell
cargo clean
```

Alternatively, you can build in release mode, which should also use less disk
space:

```shell
cargo build --release
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like this should be a pre-requisite... "Make sure you have at least XX GiB of free disk space, or use --release" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default cloud shell only gives you 5GB, if users choose that route it might be helpful to have the cargo clean tip. This happened to one of the friction log testers so it's likely to come up again from non-googlers.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I am suggesting that it belongs in the previous section.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, I moved this section to the "Setting Up Rust on Cloud Shell" section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants