Skip to content

Vision changes #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
quartzmo merged 5 commits into from
May 18, 2016
Merged

Vision changes #696

quartzmo merged 5 commits into from
May 18, 2016

Conversation

@blowmage
Copy link
Contributor

@blowmage blowmage commented May 18, 2016

Implement some requested changes to the existing Vision implementation. Including renaming Analysis to Annotation and adding support for default max results when giving a truthy value to #annotate.

require "gcloud"
gcloud = Gcloud.new

vision = gcloud.vision

annotation = vision.annotate "path/to/faces.jpg", faces: true
# As opposed to having to pass in the numeric value
# annotation = vision.annotate "path/to/faces.jpg", faces: 10

blowmage added 2 commits May 17, 2016 14:57
@blowmage
Rename Analysis to Annotation
87c9c4b 
Received feedback that analysis and analyses were not as preferred as
annotation and annotations. Rename class, update code examples and docs.
@blowmage
Allow common annotations to use default max values
f1cf742 
Add configuration for setting the default max results values.
Allow truthy values to #annotate to use the default max result values.
@blowmage blowmage added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: vision Issues related to the Cloud Vision API. labels May 18, 2016
@blowmage blowmage added this to the Vision milestone May 18, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 18, 2016
blowmage added 3 commits May 18, 2016 12:37
@blowmage
Update recommended params in Vision docs
4c8ba36 
We want to encourage users to use boolean flags instead of setting max result
values in every method call. A custom max result value can be given, but should
be presented as a secondary option to using the boolean flag.

Update method signatures to prioritize boolean flags as default values.
@blowmage
Add boolean flag tests
fc37753
@blowmage
Remove circular require warning
0913986
@quartzmo
Copy link
Member

quartzmo commented May 18, 2016

I think changing the syntax from faces: 10 to faces: true is a huge improvement in usability. It considerably lowers the friction to trying out the Vision service. For bulk (production) users, setting global configuration is also better. Win-win in my opinion.

@quartzmo quartzmo merged commit 038176a into googleapis:vision May 18, 2016
This was referenced May 18, 2016
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@quartzmo quartzmo

Labels

api: vision Issues related to the Cloud Vision API. cla: yes This human has signed the Contributor License Agreement. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Projects

None yet

Milestone

Vision

Development

Successfully merging this pull request may close these issues.

3 participants

@blowmage @quartzmo @googlebot