Skip to content

chore(billingbudgets): remove TODOs in proto comments (via synth) #9912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
busunkim96 merged 1 commit into from
Dec 6, 2019
Merged

chore(billingbudgets): remove TODOs in proto comments (via synth) #9912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions billingbudgets/google/cloud/billing_budgets_v1beta1/proto/budget_service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@ service BudgetService {
rpc CreateBudget(CreateBudgetRequest) returns (Budget) {
option (google.api.http) = {
post: "/v1beta1/{parent=billingAccounts/*}/budgets"
// (-- TODO for GA: use "budget" instead of "*" to comply with
// https://aip.dev/133. Changing in Beta would be a breaking change. --)
body: "*"
};
}
Expand All @@ -51,8 +49,6 @@ service BudgetService {
rpc UpdateBudget(UpdateBudgetRequest) returns (Budget) {
option (google.api.http) = {
patch: "/v1beta1/{budget.name=billingAccounts/*/budgets/*}"
// (-- TODO for GA: use "budget" instead of "*" to comply with
// https://aip.dev/134. Changing in Beta would be a breaking change. --)
body: "*"
};
}
Expand Down
6 changes: 3 additions & 3 deletions billingbudgets/synth.metadata
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"updateTime": "2019-11-20T13:14:31.109994Z",
"updateTime": "2019-12-04T13:14:47.368418Z",
"sources": [
{
"generator": {
Expand All @@ -12,8 +12,8 @@
"git": {
"name": "googleapis",
"remote": "https://github.com/googleapis/googleapis.git",
"sha": "16543773103e2619d2b5f52456264de5bb9be104",
"internalRef": "281423227"
"sha": "da0edeeef953b05eb1524d514d2e9842ac2df0fd",
"internalRef": "283614497"
}
},
{
Expand Down