Skip to content

Conversation

@chemelnucfin
Copy link
Contributor

Closes #4320
Diff base is #4851

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 8, 2018
@theacodes
Copy link
Contributor

Is the diffbase necessary?

@chemelnucfin
Copy link
Contributor Author

not necessary, but create_if_missing should be removed anyway.

@theacodes
Copy link
Contributor

If it can be done without it, please do. You can graft your commit onto master by using git rebase -i master and dropping the unrelated commits.

@chemelnucfin chemelnucfin force-pushed the firestore_integer_simple_fields branch from e0a5f19 to 2e72c7e Compare February 8, 2018 18:33
@chemelnucfin
Copy link
Contributor Author

that was bad, wait a minute

@chemelnucfin chemelnucfin force-pushed the firestore_integer_simple_fields branch from 2e72c7e to 640a9e7 Compare February 8, 2018 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants