Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion gcloud/datastore/key.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,10 @@ def to_protobuf(self):
key = datastore_pb.Key()

# Apparently 's~' is a prefix for High-Replication and is necessary here.
# Another valid preflix is 'e~' indicating EU datacenters.
dataset_id = self.dataset().id()
if dataset_id:
if not dataset_id.startswith('s~'):
if dataset_id[:2] not in ['s~', 'e~']:
dataset_id = 's~' + dataset_id

key.partition_id.dataset_id = dataset_id
Expand Down
14 changes: 14 additions & 0 deletions gcloud/datastore/test_key.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import unittest2

from dataset import Dataset
from key import Key


Expand All @@ -11,3 +12,16 @@ def test_init_no_arguments(self):
self.assertEqual('', key.kind())
self.assertEqual(None, key.dataset())
self.assertEqual(None, key.namespace())

def test_dataset_prefix(self):
key = Key(dataset=Dataset('dset'))
protokey = key.to_protobuf()
self.assertEqual('s~dset', protokey.partition_id.dataset_id)

key = Key(dataset=Dataset('s~dset'))
protokey = key.to_protobuf()
self.assertEqual('s~dset', protokey.partition_id.dataset_id)

key = Key(dataset=Dataset('e~dset'))
protokey = key.to_protobuf()
self.assertEqual('e~dset', protokey.partition_id.dataset_id)