Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1175 commits
Select commit Hold shift + click to select a range
4307f09
Clean up Vision unit tests.
daspecster Feb 28, 2017
8b576ad
Merge pull request #3082 from daspecster/vision-test-updates
daspecster Feb 28, 2017
6f75560
Add test file for Result class.
daspecster Feb 28, 2017
346d154
Clean up formatting and docstrings.
daspecster Feb 28, 2017
cf60802
Removing mock.Mock() in error reporting.
dhermes Feb 23, 2017
2425b41
Removing overly broad mock.Mock() in logging.
dhermes Feb 23, 2017
b5f3093
Removing overly broad mock.Mock() in vision.
dhermes Feb 23, 2017
770a821
Merge pull request #3063 from dhermes/make-mocks-less-broad
dhermes Mar 1, 2017
8b072ed
Merge pull request #3084 from daspecster/speech-tests-update
daspecster Mar 2, 2017
0e48a1d
Sending x-goog-api-client header in Bigtable.
dhermes Mar 3, 2017
6d3b70c
Making datastore Connection.begin_transaction() return low-level prot…
dhermes Mar 3, 2017
13f1435
Making datastore Connection.rollback() return low-level protobuf.
dhermes Mar 3, 2017
a743be8
Merge pull request #3091 from dhermes/fix-2746-begin_transaction
dhermes Mar 3, 2017
dc14cc9
Making datastore Connection.allocate_ids() return low-level protobuf.
dhermes Mar 3, 2017
627efc9
Merge pull request #3092 from dhermes/fix-2746-rollback
dhermes Mar 3, 2017
eea299c
Merge pull request #3089 from dhermes/bigtable-version-info
dhermes Mar 3, 2017
610f7b3
Making datastore Connection.lookup() return low-level protobuf.
dhermes Mar 3, 2017
ca95936
Cut version 0.23.1 of Bigtable.
dhermes Mar 3, 2017
4f94c57
Merge pull request #3093 from dhermes/fix-2746-allocate_ids
dhermes Mar 3, 2017
76520a7
Merge pull request #3095 from dhermes/cut-bigtable-0.23.1
dhermes Mar 3, 2017
ddaa81d
Merge pull request #3094 from dhermes/fix-2746-lookup
dhermes Mar 3, 2017
209f640
Order documentation alphabetically by service. (#3086)
lukesneeringer Mar 3, 2017
302fca7
Sending x-goog-api-client header for Datastore gRPC implementation. (…
dhermes Mar 4, 2017
5dffc63
Provide correct default encoding. (#3102)
lukesneeringer Mar 6, 2017
70b8b91
Add basic helpers needed for GAPIC client in datastore.
dhermes Feb 23, 2017
9cdec15
Moving _request and _rpc off the datastore HTTP helper.
dhermes Mar 6, 2017
3f124a5
Merge pull request #3105 from dhermes/fix-2746
dhermes Mar 6, 2017
0124db1
Merge pull request #3107 from dhermes/rework-datastore-http
dhermes Mar 6, 2017
ea4d3bc
Moving build_api_url() off of datastore Connection.
dhermes Mar 6, 2017
1cc9951
Bump language version. (#3106)
lukesneeringer Mar 6, 2017
94aaee9
Vision Beta (#3104)
lukesneeringer Mar 6, 2017
bf28ed8
Release storage-0.23.1
daspecster Mar 6, 2017
ae06a07
Only requiring HTTP object to make datastore RPC-over-HTTP.
dhermes Mar 6, 2017
b53896a
Merge pull request #3111 from daspecster/storage-0.23.1
daspecster Mar 6, 2017
98ed160
Merge pull request #3110 from dhermes/ds-drop-cnxn-in-args
dhermes Mar 6, 2017
869f4d6
Moving datastore host configuration into Client.
dhermes Mar 6, 2017
8ed17a2
Add an explicit test for records nested in records.
tseaver Mar 7, 2017
6373c2d
Add system tests for legacy data types.
tseaver Mar 7, 2017
d24d619
Merge pull request #3117 from tseaver/3029-bigquery-systest-nested_re…
tseaver Mar 7, 2017
9dea632
Merge pull request #3112 from dhermes/ds-cnxn-config-in-client
dhermes Mar 7, 2017
de2f9e9
Merge pull request #3116 from tseaver/3029-bigquery-systest-legacy_da…
tseaver Mar 8, 2017
6dc56fa
Release Error Reporting 0.23.1.
daspecster Mar 8, 2017
f9a9cdc
Merge pull request #3120 from daspecster/error-reporting-0.23.1
daspecster Mar 8, 2017
0a6a160
Using GAPIC datastore object (and an HTTP equivalent) for allocate_ids.
dhermes Mar 8, 2017
ae6caf0
'gcloud preview' command no longer supported.
daspecster Mar 8, 2017
656dde5
Merge pull request #3122 from daspecster/update-contributing-doc-for-…
daspecster Mar 8, 2017
84f71fd
Remove _BrokenResultFuture (#3101)
lukesneeringer Mar 9, 2017
1d64695
Merge pull request #3121 from dhermes/use-ds-gapic-for-allocate-ids
dhermes Mar 9, 2017
b506549
Removing _Dummy test helper classes (in favor of mocks).
dhermes Mar 9, 2017
b981e51
Merge pull request #3125 from dhermes/replace-test-_Dummy-with-mock
dhermes Mar 9, 2017
def9e13
Using GAPIC datastore object (and an HTTP equivalent) for rollback.
dhermes Mar 9, 2017
b8ca2c0
Merge pull request #3126 from dhermes/ds-move-rollback-to-gapic
dhermes Mar 9, 2017
01dffc3
Using GAPIC datastore object (and an HTTP equivalent) for commit.
dhermes Mar 9, 2017
8c0f0b3
Updating unit tests for GAPIC commit in datastore.
dhermes Mar 9, 2017
f429690
Using six.reraise to preserve traceback (Python 3 feature backport).
dhermes Mar 9, 2017
6dc7fff
Add timeout for topic_publish() for gRPC side.
daspecster Mar 10, 2017
73685a7
Merge pull request #3127 from dhermes/ds-move-commit-to-GAPIC
dhermes Mar 10, 2017
39f81bf
Using GAPIC datastore object (and an HTTP equivalent) for begin_trans…
dhermes Mar 10, 2017
5c98a6e
Merge pull request #3134 from dhermes/ds-move-begin_transaction-to-GAPIC
dhermes Mar 13, 2017
9ed6eca
Using GAPIC datastore object (and an HTTP equivalent) for run_query.
dhermes Mar 13, 2017
b3a8b48
Updating unit tests for GAPIC datastore run_query change.
dhermes Mar 13, 2017
6a375d3
Merge pull request #3137 from dhermes/ds-move-run_query-to-GAPIC
dhermes Mar 13, 2017
c877209
Using GAPIC datastore object (and an HTTP equivalent) for lookup.
dhermes Mar 13, 2017
b01768c
Updating unit test for removal of datastore Connection.
dhermes Mar 13, 2017
ebcecb7
Merge pull request #3138 from dhermes/ds-move-lookup-to-GAPIC
dhermes Mar 13, 2017
f2d5056
Merge pull request #3130 from daspecster/pubsub-publish-timeout
daspecster Mar 14, 2017
2530919
Add system test for 'Table.create' using nested schema.
tseaver Mar 7, 2017
50138d6
Added documentation from language proto (#3142)
landrito Mar 15, 2017
b873bf3
Fix double conversion of datetime for log entries.
daspecster Mar 15, 2017
ced278a
Convert batch timestamp to string.
daspecster Mar 15, 2017
0fa8823
Merge pull request #3118 from tseaver/3029-bigquery-systest-create-w-…
tseaver Mar 15, 2017
e16833f
Add system test for insert/fetch of rows w/ nested schema.
tseaver Mar 7, 2017
d9ac9b9
Merge pull request #3145 from tseaver/hygiene-setup.py-remove-unused-…
tseaver Mar 15, 2017
0f015f5
Make run_in_transaction w/ timeout test deterministic.
tseaver Mar 15, 2017
f7641d8
Adding (back) support for datastore emulator.
dhermes Mar 15, 2017
3670b86
Merge pull request #3147 from tseaver/3080-spanner-unittest-flaky-run…
tseaver Mar 16, 2017
0656330
Merge pull request #3148 from dhermes/make-ds-gapic-emulator
dhermes Mar 16, 2017
d043b13
Update speech usage document for streaming.
daspecster Mar 16, 2017
c5eaa07
Move imports in logging system tests, use _datetime_to_rfc3339.
daspecster Mar 16, 2017
5921766
Merge pull request #3153 from daspecster/update-speech-doc
daspecster Mar 16, 2017
e135dba
Provide full Mention objects, not just the content. (#3156)
lukesneeringer Mar 16, 2017
e8c9192
Fix make_report_error_api usage of Client._project.
daspecster Mar 16, 2017
10600ce
Merge pull request #3159 from daspecster/fix-error-reporting-project-…
daspecster Mar 16, 2017
6ee3a3a
Merge pull request #3144 from daspecster/fix-logging-datetime-conversion
daspecster Mar 16, 2017
72e5c59
Restoring datastore Gax exception re-mapping.
dhermes Mar 17, 2017
b1bece3
Merge pull request #3163 from dhermes/wrap-up-2746
dhermes Mar 17, 2017
f20349e
Removing unused code-path for remapping raw gRPC exceptions in datast…
dhermes Mar 17, 2017
2b7f19f
Add a `max_size` argument to Pub / Sub Batch. (#3157)
lukesneeringer Mar 20, 2017
6880cc5
Add Batch._reset_state for DRY. (#3169)
lukesneeringer Mar 20, 2017
f231ed1
Add language_hints support to detect_full_text.
daspecster Mar 20, 2017
d0c9174
Raise ValueError exception if bucket name is invalid. (#3160)
daspecster Mar 20, 2017
17875c1
Add BigQuery system test for nested-nested records.
tseaver Mar 20, 2017
752223f
Merge pull request #3171 from tseaver/2951-bigquery-insert-nested-nested
tseaver Mar 20, 2017
25f58ca
Merge branch 'master' into 3029-bigquery-systest-insert-fetch-w-compl…
tseaver Mar 20, 2017
6e81d9a
Merge pull request #3164 from dhermes/remove-dead-ds-code
dhermes Mar 20, 2017
00ed08f
Merge pull request #3170 from daspecster/add-image-context-arguments
daspecster Mar 21, 2017
e6f6af4
Adjust Spanner tests for grpcio 1.2.0 (#3178)
lukesneeringer Mar 21, 2017
14528ca
Add system tests for all scalar query parameter types. (#3173)
tseaver Mar 21, 2017
3a8ba72
Merge pull request #3140 from tseaver/3029-bigquery-systest-insert-fe…
tseaver Mar 21, 2017
536294c
Use ClientWithProject superclass for error reporting. (#3168)
lukesneeringer Mar 21, 2017
4a422f3
Fixes #3150 - Ignores resource key when it isn't present (#3177)
lucmult Mar 21, 2017
7384819
Split out systests for query params from literal values.
tseaver Mar 20, 2017
3c59583
Allow array query parameters w/ nested structs.
tseaver Mar 21, 2017
11d7a4f
Allow struct query parameters w/ nested structs.
tseaver Mar 21, 2017
0e46251
Allow struct query parameters w/ nested arrays.
tseaver Mar 21, 2017
606bd11
Update datastore batch API doc reference.
daspecster Mar 22, 2017
6b99c5c
Merge pull request #3180 from tseaver/3029-bigquery-systest-query_par…
tseaver Mar 22, 2017
478b47e
Merge pull request #3186 from daspecster/update-docs-for-ga
daspecster Mar 22, 2017
83523ca
Update references that were 301 redirecting.
daspecster Mar 22, 2017
63044bb
Updating "Faster Pull Request Reviews" link.
dhermes Mar 22, 2017
e7c25d5
Merge pull request #3189 from dhermes/update-contrib-link
dhermes Mar 22, 2017
aa4126b
Delete duplicated constant (#3190)
nownabe Mar 23, 2017
444cfd6
Update 301 redirects for storage documentation.
daspecster Mar 23, 2017
39ee8ef
Update ACL link.
daspecster Mar 23, 2017
8c7ed2b
Reduce AppVeyor matrix. (#3194)
lukesneeringer Mar 23, 2017
3a208ba
Merge pull request #3192 from daspecster/update-storage-docs-ga
daspecster Mar 23, 2017
7654ee4
Update redirects and references for BigQuery docs.
daspecster Mar 23, 2017
12442fa
Ensure that base64-encoded bytes get decoded to text for JSON. (#3195)
tseaver Mar 23, 2017
3a3c4c9
Merge pull request #3196 from daspecster/update-bigquery-docs-ga
daspecster Mar 23, 2017
4539738
Update NL documentation references.
daspecster Mar 23, 2017
a8e4211
Fix broken speech link.
daspecster Mar 23, 2017
a5ca44a
Merge pull request #3197 from daspecster/update-natural-language-docs…
daspecster Mar 23, 2017
472a553
Merge pull request #3198 from daspecster/update-speech-docs-for-beta
daspecster Mar 23, 2017
7561e15
Fix translate links. (#3199)
daspecster Mar 23, 2017
9baade9
CI Rehash (#3146)
lukesneeringer Mar 23, 2017
7d2d8b3
Remove storage acl chaining from docs. (#3201)
daspecster Mar 24, 2017
bfcc828
Merge pull request #3187 from daspecster/update-logging-docs-ga
daspecster Mar 24, 2017
eb33458
Fix typo in docstring google.cloud.core._helpers (#3207)
craigcitro Mar 24, 2017
5ca4362
Fixing up some format strings in nox configs.
dhermes Mar 27, 2017
c6fb5df
Fix vision documentation redirects and references. (#3202)
daspecster Mar 27, 2017
823a5a7
Merge pull request #3213 from dhermes/perfect-formatting-eeek
dhermes Mar 27, 2017
3dae283
Prep error-reporting-0.23.2 (#3217)
tseaver Mar 28, 2017
b1fe92f
Add integration test for Unicode filenames. (#3215)
lukesneeringer Mar 28, 2017
f243812
Check out docs submodule with SSH. (#3223)
lukesneeringer Mar 28, 2017
affdd28
Fix encryption example, remove document policy example. (#3221)
daspecster Mar 28, 2017
6707530
Be forviging on a flaky test. (#3225)
lukesneeringer Mar 28, 2017
ef06f58
Fix the docs. (#3226)
lukesneeringer Mar 28, 2017
1b6c579
Small updates to Vision examples.
daspecster Mar 28, 2017
adca1c6
Merge pull request #3227 from daspecster/update-vision-examples
daspecster Mar 28, 2017
dc4ebae
Make flaky tests retry. (#3229)
lukesneeringer Mar 28, 2017
b92ceab
Add policy_document snippet back.
daspecster Mar 28, 2017
33e32a5
Merge pull request #3231 from daspecster/add-policy-document-snippet-…
daspecster Mar 28, 2017
a99a12f
Revert "Fix make_report_error_api usage of Client._project."
DizzeePascall Mar 29, 2017
3b3cc65
Merge pull request #3234 from DizzeePascall/fix-error-reporting-proje…
dhermes Mar 29, 2017
6ba1512
Update exceptions.py
bootandy Mar 30, 2017
dae289c
Merge pull request #3239 from bootandy/patch-1
daspecster Mar 30, 2017
9cb1e37
Fix broken language examples. (#3220)
daspecster Mar 30, 2017
26cfff9
Make clients explicitly unpickleable. (#3230)
lukesneeringer Mar 30, 2017
00ee0fa
Fix untested snippet examples. (#3219)
daspecster Mar 30, 2017
e415799
Update speech usage examples. (#3206)
daspecster Mar 30, 2017
754888b
Add docs for 'result_index' usage and a system test.
daspecster Mar 30, 2017
87d902e
Renaming http argument(s) as _http. (#3235)
dhermes Mar 30, 2017
67f9d4d
Merge pull request #3241 from daspecster/speech-add-result-index
daspecster Mar 30, 2017
9ded5f6
Fixing usage of http= vs. _http= in core unit test. (#3243)
dhermes Mar 30, 2017
5bf89d6
Make logging system tests verbose. (#3244)
lukesneeringer Mar 30, 2017
95b5f33
Revert "Add docs for 'result_index' usage and a system test." (#3249)
daspecster Mar 30, 2017
13abcf6
GA and Beta Promotions (#3245)
lukesneeringer Mar 30, 2017
f6f6a32
Removing most remnants of Travis CI. (#3250)
dhermes Mar 30, 2017
038cf75
Adding CircleCI 1.0 config into our 2.0 config to support tag builds.
dhermes Mar 31, 2017
3a6f285
Merge pull request #3253 from dhermes/tag-build-on-circle-2.0
dhermes Mar 31, 2017
02c2459
Update get_target_packages to account for CIRCLE_TAG.
dhermes Mar 31, 2017
e0bf420
Merge pull request #3254 from dhermes/limit-pkgs-on-tag-build
dhermes Mar 31, 2017
12568b1
Not pushing docs on tag builds.
dhermes Mar 31, 2017
105c331
Merge pull request #3255 from dhermes/no-docs-on-tags
dhermes Mar 31, 2017
0616229
Fixing "repo-relative" directory in `get_tagged_package`.
dhermes Mar 31, 2017
2c272b5
Merge pull request #3256 from dhermes/fix-twine-upload-bug
dhermes Mar 31, 2017
bdc0030
Add twine and setuptools install as step before twine upload. (#3257)
dhermes Mar 31, 2017
f3b45d9
Use Python 3 for package build.
Mar 31, 2017
098d92b
Merge pull request #3258 from lukesneeringer/python3-setuptools
dhermes Mar 31, 2017
7464d53
Downgrading logging from 1.0.0 to 0.24.0.
dhermes Apr 1, 2017
e2cd207
Merge pull request #3261 from dhermes/logging-version-downgrade
dhermes Apr 1, 2017
ff9ff61
Fix repeated spelling error (#3260)
kkinder Apr 3, 2017
95481dc
Fix missing BYTES merger
samizuh Apr 4, 2017
5940474
Factor common IAM policy bits into 'google.cloud.iam'.
tseaver Mar 22, 2017
0eed2f5
Accomodate (future) user-defined roles.
tseaver Mar 23, 2017
2e80f07
Add API documentation for 'google.cloud.iam'.
tseaver Mar 23, 2017
b3f644e
Address review:
tseaver Mar 23, 2017
dbfc116
Update pubsub snipets to accomodate changed semantics.
tseaver Mar 23, 2017
f29bef3
Speech v1 (#3266)
lukesneeringer Apr 5, 2017
21047b0
Accomodate noxification.
tseaver Apr 5, 2017
9dcf5b4
Return frozensets from named Policy properties.
tseaver Apr 5, 2017
f95e997
Drop fossil docs refs to 'read_streaming'/'execute_streaming_sql'. (#…
tseaver Apr 6, 2017
6b84f88
Make IAM Policy objects dict-line.
tseaver Apr 6, 2017
a49e350
Deprecate assignment to legacy role attributes.
tseaver Apr 6, 2017
6f89dd0
Gracefully continue if LogEntry.proto_payload type URL is not in regi…
dhermes Apr 6, 2017
3020a82
test case for BYTES merger
samizuh Apr 6, 2017
772db29
Cut release 1.0.0 of logging package. (#3278)
dhermes Apr 7, 2017
80f8f92
Bump Speech to 0.25.0. (#3280)
lukesneeringer Apr 7, 2017
8e8b82f
Make sentiment.score optional. (#3282)
lukesneeringer Apr 11, 2017
6a24148
Language: Expose an api_version parameter on the Client. (#3283)
lukesneeringer Apr 11, 2017
c82414e
Version number bump. [ci skip] (#3289)
lukesneeringer Apr 11, 2017
0687af8
Do not validate sample rate. (#3290)
lukesneeringer Apr 12, 2017
0741a02
Add new encodings. (#3292)
lukesneeringer Apr 12, 2017
2af68e3
Do not force LRO to be LINEAR16 only in Speech. (#3291)
lukesneeringer Apr 12, 2017
006c0d9
Bump Speech to 0.25.1 (#3297)
lukesneeringer Apr 13, 2017
4dd2da6
Add Pub/Sub snapshot and seek functionality
geigerj Apr 11, 2017
0f91d1f
Replace httpContext with httpRequest (#3299)
waprin Apr 17, 2017
1cb4ab0
Update speech docs to remove incorrect warnings. (#3305)
lukesneeringer Apr 17, 2017
def8eff
Coerce role-principal values to frozenset.
Apr 12, 2017
f270f5c
Merge pull request #3188 from tseaver/1679-generalize-pubsub-iam-for-…
tseaver Apr 17, 2017
4605801
Add new subscription fields
geigerj Apr 17, 2017
3894254
Merge pull request #3271 from samizuh/patch-1
tseaver Apr 18, 2017
908d108
Merge pull request #3307 from geigerj/subscription-fields
geigerj Apr 18, 2017
e89cda1
Store policy bindings as sets, not frozensets. (#3308)
tseaver Apr 19, 2017
60b4c38
Add IAM methods for buckets. (#3309)
tseaver Apr 19, 2017
c7f36cb
Add IAM handlers to blobs (#3311)
tseaver Apr 19, 2017
380377a
Merge branch 'public-master' into snap-seek2
Apr 19, 2017
3b060ce
Change if/elif to if/if.
Apr 19, 2017
0e4ece8
Merge branch 'public-master' into snap-seek2
Apr 19, 2017
d1c197e
Merge pull request #3303 from geigerj/snap-seek2
geigerj Apr 19, 2017
8d9bb35
Fix a system test TODO (#3314)
geigerj Apr 19, 2017
8e73d35
Adding check (in datastore) that setup.py README is valid RST. (#3316)
dhermes Apr 20, 2017
4c17230
Adding check that **all** setup.py README's are valid RST. (#3318)
dhermes Apr 20, 2017
cb8a355
Update BQ Query parameter reference
roscoejp Apr 21, 2017
f4c1b72
Fix line length
roscoejp Apr 21, 2017
4dc1bef
Fix trailing whitespace
roscoejp Apr 21, 2017
f540fbe
Ignore tests (rather than unit_tests) in setup.py files. (#3319)
dhermes Apr 21, 2017
93a2607
Include full API reference
roscoejp Apr 24, 2017
20cc0f8
Fix line length
roscoejp Apr 24, 2017
153c4b9
Swapping out google.streaming for google-resumable-media in GCS downl…
dhermes Apr 24, 2017
12e81f8
Pass client credentials through to instance / database admin API inst…
tseaver Apr 25, 2017
4a37b62
Merge pull request #3326 from tseaver/3070-spanner-pass_explicit_cred…
tseaver Apr 25, 2017
677d773
Fixing broken logging system test. (#3325)
dhermes Apr 27, 2017
145f5d3
Making Blob.storage_class settable. (#3328)
dhermes Apr 27, 2017
3546f7f
Adding scope to error reporting client. (#3334)
dhermes Apr 27, 2017
eaf7bd4
Allowing "dank" or "danke" when "dankon" translated from Esperanto to…
dhermes Apr 27, 2017
3501c26
Adding error remapping for Blob.download_to_file(). (#3338)
dhermes Apr 27, 2017
2e499c2
Merge pull request #3320 from roscoejp/master
tseaver Apr 27, 2017
c43b496
Cut releases of core, error reporting, pubsub, spanner and storage. (…
dhermes Apr 28, 2017
51a38da
Fix `speech_context` typo in speech-usage docs. (#3350)
alexchao May 2, 2017
920be37
Only using Blob.updated if it is set in download_to_filename(). (#3352)
dhermes May 2, 2017
37107a5
Bugfix release of Storage. (#3353)
dhermes May 2, 2017
0164a4e
Enforcing explicit UTF-8 blob name. (#3354)
dhermes May 2, 2017
a2f3c74
Making the google-cloud setup.py valid. (#3358)
dhermes May 2, 2017
adf5054
Factoring out some Blob helpers. (#3357)
dhermes May 2, 2017
2661079
Incorrect error creating empty partitioned table
richkadel May 4, 2017
8c3100c
Incorrect error creating empty partitioned table
May 4, 2017
4909232
Slight correction
richkadel May 4, 2017
6617f04
Slight correction
May 4, 2017
52bb3a1
fixed line too long
richkadel May 4, 2017
78d853d
fixed line too long
May 4, 2017
be12c01
updated tests for coverage
richkadel May 4, 2017
ebc088b
updated tests for coverage
May 4, 2017
84f0c8c
fixed my own mistake copying test case
richkadel May 6, 2017
c6fe35f
fixed my own mistake copying test case
May 6, 2017
9e8e777
now it tests, but value was off...
May 6, 2017
55f2d95
now it tests, but value was off...
richkadel May 6, 2017
c910510
now it tests, but value was off...
May 6, 2017
7a31712
Merge branch 'patch-1' of https://github.com/richkadel/google-cloud-p…
May 6, 2017
b54a9ae
Merge branch 'patch-1' of https://github.com/richkadel/google-cloud-p…
May 6, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions bigquery/google/cloud/bigquery/table.py
Original file line number Diff line number Diff line change
Expand Up @@ -473,8 +473,9 @@ def _build_resource(self):
resource['schema'] = {
'fields': _build_schema_resource(self._schema)
}
else:
raise ValueError("Set either 'view_query' or 'schema'.")
elif self.partitioning_type is None:
raise ValueError(
"Set either 'view_query' or 'schema' or 'partitioning_type'.")

return resource

Expand Down
26 changes: 25 additions & 1 deletion bigquery/tests/unit/test_table.py
Original file line number Diff line number Diff line change
Expand Up @@ -395,14 +395,38 @@ def test_from_api_repr_w_properties(self):
self.assertIs(table._dataset._client, client)
self._verifyResourceProperties(table, RESOURCE)

def test_create_no_view_query_no_schema(self):
def test_create_no_view_query_no_schema_no_partitioning(self):
conn = _Connection()
client = _Client(project=self.PROJECT, connection=conn)
dataset = _Dataset(client)
table = self._make_one(self.TABLE_NAME, dataset)

with self.assertRaises(ValueError):
table.create()

def test_create_new_day_partitioned_table(self):
PATH = 'projects/%s/datasets/%s/tables' % (self.PROJECT, self.DS_NAME)
RESOURCE = self._makeResource()
conn = _Connection(RESOURCE)
client = _Client(project=self.PROJECT, connection=conn)
dataset = _Dataset(client)
table = self._make_one(self.TABLE_NAME, dataset)
table.partitioning_type = 'DAY'
table.create()

self.assertEqual(len(conn._requested), 1)
req = conn._requested[0]
self.assertEqual(req['method'], 'POST')
self.assertEqual(req['path'], '/%s' % PATH)
SENT = {
'tableReference': {
'projectId': self.PROJECT,
'datasetId': self.DS_NAME,
'tableId': self.TABLE_NAME},
'timePartitioning': {'type': 'DAY'},
}
self.assertEqual(req['data'], SENT)
self._verifyResourceProperties(table, RESOURCE)

def test_create_w_bound_client(self):
from google.cloud.bigquery.table import SchemaField
Expand Down