Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions gcloud/bigquery/table.py
Original file line number Diff line number Diff line change
Expand Up @@ -717,7 +717,8 @@ def insert_data(self,

return errors

def upload_from_file(self, # pylint: disable=R0913,R0914
# pylint: disable=too-many-arguments,too-many-locals
def upload_from_file(self,
file_obj,
source_format,
rewind=False,
Expand Down Expand Up @@ -890,9 +891,10 @@ def upload_from_file(self, # pylint: disable=R0913,R0914
six.string_types): # pragma: NO COVER Python3
response_content = response_content.decode('utf-8')
return client.job_from_resource(json.loads(response_content))
# pylint: enable=too-many-arguments,too-many-locals


def _configure_job_metadata(metadata, # pylint: disable=R0913
def _configure_job_metadata(metadata, # pylint: disable=too-many-arguments
allow_jagged_rows,
allow_quoted_newlines,
create_disposition,
Expand Down
5 changes: 3 additions & 2 deletions gcloud/bigquery/test_table.py
Original file line number Diff line number Diff line change
Expand Up @@ -1404,7 +1404,7 @@ def test_upload_from_file_w_bound_client_multipart(self):
payload_lines = app_msg._payload.rstrip().splitlines()
self.assertEqual(payload_lines, body_lines)

# pylint: disable=R0915
# pylint: disable=too-many-statements
def test_upload_from_file_w_explicit_client_resumable(self):
import json
from six.moves.http_client import OK
Expand Down Expand Up @@ -1490,6 +1490,7 @@ class _UploadConfig(object):
'bytes 0-%d/%d' % (length - 1, length))
self.assertEqual(headers['content-length'], '%d' % (length,))
self.assertEqual(req['body'], BODY)
# pylint: enable=too-many-statements


class Test_parse_schema_resource(unittest2.TestCase, _SchemaBase):
Expand Down Expand Up @@ -1606,7 +1607,7 @@ def __init__(self, project='project', connection=None):
self.project = project
self.connection = connection

def job_from_resource(self, resource): # pylint: disable=W0613
def job_from_resource(self, resource): # pylint: disable=unused-argument
return self._job


Expand Down
1 change: 0 additions & 1 deletion gcloud/streaming/test_transfer.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
# pylint: disable=C0302
import unittest2


Expand Down
4 changes: 4 additions & 0 deletions scripts/pylintrc_default
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,9 @@ load-plugins=pylint.extensions.check_docs
# """Hi everyone"""
# and thus causes subsequent imports to be
# diagnosed as out-of-order.
# - no-name-in-module: Error gives a lot of false positives for names which
# are defined dynamically. Also, any truly missing names
# will be detected by our 100% code coverage.
disable =
maybe-no-member,
no-member,
Expand All @@ -95,6 +98,7 @@ disable =
star-args,
redefined-variable-type,
wrong-import-position,
no-name-in-module,


[REPORTS]
Expand Down
2 changes: 1 addition & 1 deletion scripts/run_pylint.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
}
TEST_RC_REPLACEMENTS = {
'FORMAT': {
'max-module-lines': 1700,
'max-module-lines': 1900,
},
}

Expand Down
2 changes: 0 additions & 2 deletions system_tests/bigtable.py
Original file line number Diff line number Diff line change
Expand Up @@ -231,10 +231,8 @@ def test_create_table(self):
self.assertEqual(sorted_tables, expected_tables)

def test_rename_table(self):
# pylint: disable=no-name-in-module
from grpc.beta import interfaces
from grpc.framework.interfaces.face import face
# pylint: enable=no-name-in-module

temp_table_id = 'foo-bar-baz-table'
temp_table = Config.CLUSTER.table(temp_table_id)
Expand Down