Skip to content

feat(iam): undeprecate resource name helper methods, add 2.7 deprecation warning (via synth) #10043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
busunkim96 merged 1 commit into from
Jan 8, 2020
Merged

feat(iam): undeprecate resource name helper methods, add 2.7 deprecation warning (via synth) #10043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions iam/google/cloud/iam_credentials_v1/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,22 @@


from __future__ import absolute_import
import sys
import warnings

from google.cloud.iam_credentials_v1 import types
from google.cloud.iam_credentials_v1.gapic import iam_credentials_client


if sys.version_info[:2] == (2, 7):
message = (
"A future version of this library will drop support for Python 2.7."
"More details about Python 2 support for Google Cloud Client Libraries"
"can be found at https://cloud.google.com/python/docs/python2-sunset/"
)
warnings.warn(message, DeprecationWarning)


class IAMCredentialsClient(iam_credentials_client.IAMCredentialsClient):
__doc__ = iam_credentials_client.IAMCredentialsClient.__doc__

Expand Down
7 changes: 1 addition & 6 deletions iam/google/cloud/iam_credentials_v1/gapic/iam_credentials_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,12 +83,7 @@ def from_service_account_file(cls, filename, *args, **kwargs):

@classmethod
def service_account_path(cls, project, service_account):
"""DEPRECATED. Return a fully-qualified service_account string."""
warnings.warn(
"Resource name helper functions are deprecated.",
PendingDeprecationWarning,
stacklevel=1,
)
"""Return a fully-qualified service_account string."""
return google.api_core.path_template.expand(
"projects/{project}/serviceAccounts/{service_account}",
project=project,
Expand Down
Loading