Skip to content

pubsub: make Publisher use GAPIC client #3008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pongad merged 6 commits into from
Mar 14, 2018
Merged

pubsub: make Publisher use GAPIC client #3008

pongad merged 6 commits into from
Mar 14, 2018

Conversation

@pongad
Copy link
Contributor

@pongad pongad commented Mar 7, 2018

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 7, 2018
pongad
pongad commented Mar 7, 2018
View reviewed changes
google-cloud-pubsub/src/test/java/com/google/cloud/pubsub/v1/PublisherImplTest.java
publisher.shutdown();
}

public void testPublishFailureRetries_exceededsRetryDuration() throws Exception {

This comment was marked as spam.

Sign in to view

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/TopicAdminSettings.java Outdated

/** Returns the object with the settings used for calls to publish. */
/* package-private */ BatchingCallSettings<PublishRequest, PublishResponse> publishSettings() {
/* package-private */ UnaryCallSettings<PublishRequest, PublishResponse> publishSettings() {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@garrettjonesgoogle
Copy link
Member

garrettjonesgoogle commented Mar 7, 2018

@hzyi-google could you do the first pass?

yihanzhen
yihanzhen reviewed Mar 7, 2018
View reviewed changes
google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/stub/PublisherStubSettings.java Outdated
.setRetryableCodes(RETRYABLE_CODE_DEFINITIONS.get("non_idempotent"))
.setRetrySettings(RETRY_PARAM_DEFINITIONS.get("default"));

// builder

This comment was marked as spam.

Sign in to view

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/stub/PublisherStubSettings.java Outdated
BatchingCallSettings.newBuilder(PUBLISH_BATCHING_DESC)
.setBatchingSettings(BatchingSettings.newBuilder().build());
publishSettings = UnaryCallSettings.newUnaryCallSettingsBuilder();
// publishSettings =

This comment was marked as spam.

Sign in to view

@pongad
Copy link
Contributor Author

pongad commented Mar 8, 2018

@hzyi-google PTAL

@yihanzhen
Copy link
Contributor

yihanzhen commented Mar 8, 2018

LGTM

@pongad
Copy link
Contributor Author

pongad commented Mar 8, 2018

@garrettjonesgoogle \Do you also want to take a look?

garrettjonesgoogle
garrettjonesgoogle reviewed Mar 9, 2018
View reviewed changes
google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java Outdated

private final Channel channel;
@Nullable private final CallCredentials callCredentials;
private final TopicAdminClient topicClient;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java
closeables =
Collections.<AutoCloseable>singletonList(new ExecutorAsBackgroundResource(executor));
} else {
closeables = Collections.emptyList();

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java Outdated
try {
ApiException gaxException =
ApiExceptionFactory.createException(
t, GrpcStatusCode.of(Status.fromThrowable(t).getCode()), false);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@pongad
Copy link
Contributor Author

pongad commented Mar 13, 2018

@garrettjonesgoogle PTAL

@pongad
Copy link
Contributor Author

pongad commented Mar 14, 2018

@garrettjonesgoogle Committed the test now

garrettjonesgoogle
garrettjonesgoogle approved these changes Mar 14, 2018
View reviewed changes
Copy link
Member

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pongad pongad merged commit 7f88505 into googleapis:master Mar 14, 2018
@pongad pongad deleted the pubsub-gapic branch March 14, 2018 21:44
@pongad
Copy link
Contributor Author

pongad commented Mar 14, 2018

Thank you @garrettjonesgoogle . Sorry for the churn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@yihanzhen yihanzhen yihanzhen left review comments

@garrettjonesgoogle garrettjonesgoogle garrettjonesgoogle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pongad @garrettjonesgoogle @yihanzhen @googlebot