bigquery: properly handle empty array params #2695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2678. If the param is an empty array, the server sends us a null value, not a value with empty array. This commit makes us detect nulls properly. Also move to AutoValue. This fixes a latent bug where the array value might be mutable.
googlebot
added
the
cla: yes
tswast
approved these changes
Dec 11, 2017
Contributor
tswast
left a comment
tswast
left a comment
There was a problem hiding this comment.
Regarding AutoValue, I assume that in the actual released package users will not need any compiler plugins, right? We've encountered a lot of trouble when people use samples with AutoValue (mostly with people using the built-in Eclipse compiler and not Maven directly), but I think in the case of samples the compiler plugin is unavoidable.
Contributor
Author
|
Yup! Our tools should auto-generate the AutoValue classes and package them along with other things sent to Maven. The users shouldn't know we're using AutoValue aside from the fact that docs will have Will hold off until GCJ releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2678.
If the param is an empty array, the server sends us
a null value, not a value with empty array.
This commit makes us detect nulls properly.
Also move to AutoValue. This fixes a latent bug where the array value
might be mutable.