Skip to content

chore(internal/gapicgen): fix print to not panic #6583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 2, 2022
Merged

chore(internal/gapicgen): fix print to not panic #6583

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bd4654b
chore(internal/gapicgen): fix print to not panic
codyoss Aug 29, 2022
3a75018
Merge branch 'main' into fixitfast
codyoss Aug 29, 2022
026fedd
Merge branch 'main' into fixitfast
codyoss Aug 29, 2022
d9aff1e
Merge branch 'main' into fixitfast
codyoss Sep 2, 2022
997940f
Merge branch 'main' into fixitfast
gcf-merge-on-green[bot] Sep 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/gapicgen/generator/genproto.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ func (g *GenprotoGenerator) Regen(ctx context.Context) error {
return g.protoc(fn, grpc)
})
} else {
log.Panicf("skipping, %q has been migrated", pkg)
log.Printf("skipping, %q has been migrated", pkg)
}
}
if err := grp.Wait(); err != nil {
Expand Down