fix: make collections import compatible across Python versions #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jay0lee
changed the title
busunkim96
added
the
kokoro:run
yoshi-kokoro
removed
the
kokoro:run
plamut
suggested changes
Jan 17, 2020
Contributor
There was a problem hiding this comment.
@jay0lee Thanks for the fix!
Unfortunately, this library technically still supports Python 2.7, thus the import needs to be made in a compatible way for a little longer.
(the README does say January 1st 2020, but IIRC the support is extended until April 2020 when the last Python 2.7 bugfix release is made)
plamut
changed the title
fanghuaqi
added a commit
to Nuclei-Software/nuclei-sdk
that referenced
this pull request
Jul 25, 2022
googleapis/google-auth-library-python#419 Signed-off-by: Huaqi <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #418.
Use collections.abc.Mapping instead of deprecated collections.Mapping that will be removed with Python 3.9.