[refactor] Remove the proto.top attribute.
#90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is essentially never a point in template writing where it is *not* desirable to use top, so just use it all the time. Refactors the original `messages` and `enums` properties to `all_messages` and `all_enums`. Fixes #84.
lukesneeringer
force-pushed
the
remove-top
branch
from
aded86e to
d9bebc0
Compare
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 16 16
Lines 733 736 +3
Branches 150 151 +1
=====================================
+ Hits 733 736 +3
Continue to review full report at Codecov.
|
alexander-fenster
approved these changes
Jan 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is essentially never a point in template writing where it is not desirable to use top, so just use it all the time.
Refactors the original
messagesandenumsproperties toall_messagesandall_enums.Fixes #84.