[fix] Pager modules must always import the message being paged. #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This commit fixes an issue where a `pagers.py` file would sometimes be missing an import (it would always import the request and response message, but not necessarily the message being paged over). Fixes #150.
lukesneeringer
force-pushed
the
issue-150
branch
from
1cb1206 to
e3eb276
Compare
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 22 22
Lines 1017 1017
Branches 213 213
=====================================
Hits 1017 1017Continue to review full report at Codecov.
|
busunkim96
approved these changes
Jul 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue where a
pagers.pyfile would sometimesbe missing an import (it would always import the request and
response message, but not necessarily the message being paged over).
Fixes #150.