[feat] Improve enums. #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses proto-plus enums, which add enum support to the marshal and cause enums (rather than ints) to be returned, and add support for accepting strings.
Contributor
Author
|
This is thoroughly tested in proto plus, but I have no good way to write an integration test here due to the lack of enums in Showcase. Filed googleapis/gapic-showcase#142 on Showcase to address this. |
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 18 18
Lines 772 772
Branches 168 168
=====================================
Hits 772 772Continue to review full report at Codecov.
|
alexander-fenster
approved these changes
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses proto-plus enums, which add enum support to the marshal and cause enums (rather than ints) to be returned, and add support for accepting strings.