[feat] Add a CLI option to set the Python module #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #126 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 18 18
Lines 764 772 +8
Branches 164 168 +4
=====================================
+ Hits 764 772 +8
Continue to review full report at Codecov.
|
alexander-fenster
approved these changes
May 26, 2019
lukesneeringer
pushed a commit
that referenced
this pull request
May 28, 2019
This is a follow-up to #126, where I added a CLI option, but neglected to update the Docker entrypoint script to actually pass it on to the generator, making the option useless when using Docker (the common case for now). This updates the script to be more robust, and check the prefix rather than an index of every known option.
lukesneeringer
pushed a commit
that referenced
this pull request
May 28, 2019
This is a follow-up to #126, where I added a CLI option, but neglected to update the Docker entrypoint script to actually pass it on to the generator, making the option useless when using Docker (the common case for now). This updates the script to be more robust, and check the prefix rather than an index of every known option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to translate between the actual proto package and the desired Python module when automatic inference does the wrong thing (e.g. think
google.spanner.v1->google.cloud.spanner_v1).