[fix] Fix unit test generation for services with no default host. #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukesneeringer
force-pushed
the
fix-no-host-test
branch
from
b299011 to
515e41d
Compare
Codecov Report
@@ Coverage Diff @@
## master #120 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 16 16
Lines 746 746
Branches 159 159
=====================================
Hits 746 746Continue to review full report at Codecov.
|
alexander-fenster
approved these changes
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
defaultfilter was not working in this case because it normally only triggers onjinja2.Undefined, not on falsy values (and this wasNone).