[ci] invert the condition on all-jobs-succeeded #457
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlf
previously approved these changes
Oct 4, 2023
jswrenn
force-pushed
the
task-failed-successfully
branch
from
5aa913e to
254be7b
Compare
jswrenn
force-pushed
the
task-failed-successfully
branch
from
254be7b to
2f54837
Compare
Previously, a failing job could cause all-jobs-succeed to be skipped, and branch protections interpreted a skipped job as being vacuously successful. This failure mode caused #454 to be merged to main, despite failing many CI checks. This PR inverts the `if` condition of this job: It only runs on failure, and upon failure, it fails.
jswrenn
force-pushed
the
task-failed-successfully
branch
from
2f54837 to
cddaacb
Compare
Member
|
Looks like |
Member
|
Confirmed in #461 (comment) that #460 fixed the issue. |
auto-merge was automatically disabled
October 4, 2023 15:54
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a failing job could cause all-jobs-succeeded to be skipped, and branch protections interpreted a skipped job as being vacuously successful. This failure mode caused #454 to be merged to main, despite failing many CI checks.
This PR inverts the
ifcondition of this job: It only runs on failure, and upon failure, it fails.