Skip to content

[CI] Remove CARGO_NET_RETRY override #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshlf merged 1 commit into from
Sep 4, 2023
Merged

[CI] Remove CARGO_NET_RETRY override #324

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,6 @@ permissions: read-all

env:
CARGO_TERM_COLOR: always
# Increased from the default value of 3 in order to address #295. As of that issue's
# writing, we were experiencing a few failures per 149 jobs due to network timeouts.
# This implies a failure rate of (very roughly) 1 in 50. Assuming statistically
# independent network failures (probably a bad assumption, but we can't really do
# better without a lot more investigating), every subsequent 3 retries should reduce
# the incidence of failures 50-fold. Setting this to 9 should result in a failure
# rate of 1 in 125,000. Assuming 149 jobs per PR, we should expect at least one
# failure per set of 149 jobs to occur with 1 - (1 - (1/125000))^149 = 0.001%
# probability, which is plenty low enough to not meaningfully impact development.
CARGO_NET_RETRY: 9
RUSTFLAGS: -Dwarnings
RUSTDOCFLAGS: -Dwarnings
# `ZC_NIGHTLY_XXX` are flags that we add to `XXX` only on the nightly
Expand Down