Cache the dependencies #302
Conversation
Append a new line to avoid the previous cache
joshlf
left a comment
joshlf
left a comment
There was a problem hiding this comment.
Okay, I think this is in a good state other than a few small cleanup items. Thanks so much for your work on this, @zoo868e! Very excited to have more reliable jobs - they've been failing a lot recently and causing a lot of headache.
In this commit, we optimize the population of the global Cargo registry and cache in the CI workflow. By populating the cache before running the jobs in the matrix, we avoid redundant downloads of crates from the internet, improving overall workflow efficiency. We also include the following changes: - Removed the 'Clean build artifacts' step, as it's no longer needed after cache population. - Added comments to clarify the purpose of the 'Populate cache' step and its best-effort nature. These changes enhance the CI workflow's performance and ensure that dependencies are efficiently managed during the build process.
joshlf
left a comment
joshlf
left a comment
There was a problem hiding this comment.
Okay, just looks like we need to remove -test-CI2- from the cache keys and then this should be good to go!
The caching introduced in #302 fixes the issue that this override was meant to address, so it's no longer necessary.
|
Awesome, thanks so much for all your work on this, @zoo868e! At least based on how the jobs ran on this PR, I expect this is going to almost entirely fix the issue (perhaps with the exception of cases where populating the cache itself fails, which should presumably be much less common than at least one of 149 jobs failing for the same reason). |
The caching introduced in #302 fixes the issue that this override was meant to address, so it's no longer necessary.
2 participants
Fixes #295