[derive] Make output tests insensitive to syntax #1711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1711 +/- ##
==========================================
- Coverage 88.98% 88.79% -0.20%
==========================================
Files 16 16
Lines 5830 5843 +13
==========================================
Hits 5188 5188
- Misses 642 655 +13 ☔ View full report in Codecov by Sentry. |
jswrenn
approved these changes
Sep 20, 2024
djkoloski
reviewed
Sep 20, 2024
zerocopy-derive/src/output_tests.rs
Outdated
| if expect != res { | ||
| let diff = dissimilar::diff(&expect, &res) | ||
| .into_iter() | ||
| .map(|chunk| { |
Member
There was a problem hiding this comment.
Per CI failures, use flat_map here
Our previous output tests asserted on the exact token stream, which is sensitive to subtle differences like `> >` vs `>>` in type signatures. With this change, we instead test for string equality *after* performing a pretty-printing pass, which has the effect of normalizing most such differences, thus making our tests more robust and less sensitive to these inconsequential syntax details.
joshlf
force-pushed
the
derive-test-output-diff
branch
from
96095cb to
0a21c86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our previous output tests asserted on the exact token stream, which is sensitive to subtle differences like
> >vs>>in type signatures. With this change, we instead test for string equality after performing a pretty-printing pass, which has the effect of normalizing most such differences, thus making our tests more robust and less sensitive to these inconsequential syntax details.