Skip to content

Conversation

@joshlf
Copy link
Member

@joshlf joshlf commented Sep 19, 2024

Makes progress on #1634

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.01%. Comparing base (70f3e14) to head (81609bd).
⚠️ Report is 402 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1683   +/-   ##
=======================================
  Coverage   88.01%   88.01%           
=======================================
  Files          16       16           
  Lines        5805     5805           
=======================================
  Hits         5109     5109           
  Misses        696      696           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

TryFromBytes {
#[repr(u8)]
enum ComplexWithGenerics<X, Y> {
enum ComplexWithGenerics<'a, const N: usize, X, Y: Deref>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to also make sure that inline lifetime bounds are forwarded:

Suggested change
enum ComplexWithGenerics<'a, const N: usize, X, Y: Deref>
enum ComplexWithGenerics<'a: 'static, const N: usize, X, Y: Deref>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@joshlf joshlf force-pushed the try-from-bytes-derive-tests branch from 8c06722 to 81609bd Compare September 19, 2024 18:08
@joshlf joshlf added this pull request to the merge queue Sep 19, 2024
Merged via the queue into main with commit 04386e9 Sep 19, 2024
@joshlf joshlf deleted the try-from-bytes-derive-tests branch September 19, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants