[derive] Test exact output of derives #1664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1664 +/- ##
=======================================
Coverage 88.01% 88.01%
=======================================
Files 16 16
Lines 5805 5805
=======================================
Hits 5109 5109
Misses 696 696 ☔ View full report in Codecov by Sentry. |
jswrenn
reviewed
Sep 16, 2024
| // validities of its fields, so this is a sound implementation of | ||
| // `is_bit_valid`. | ||
| fn is_bit_valid<A: ::zerocopy::pointer::invariant::Aliasing + ::zerocopy::pointer::invariant::AtLeast<::zerocopy::pointer::invariant::Shared>>( | ||
| fn is_bit_valid<A: ::zerocopy::pointer::invariant::Aliasing + ::zerocopy::pointer::invariant::AtLeast<::zerocopy::pointer::invariant::Shared> >( |
Member
Author
There was a problem hiding this comment.
>> is the right-shift token while > > is two separate tokens. This matters because these tests care about the exact sequence of tokens.
jswrenn
requested changes
Sep 16, 2024
| fn test_known_layout() { | ||
| test_derive! { | ||
| KnownLayout { | ||
| struct Foo; |
Collaborator
There was a problem hiding this comment.
Let's exercise a bit more of the derive:
Suggested change
| struct Foo; | |
| struct UnitLike<const N: usize> | |
| where | |
| for<'a> Foo<N>: Sized; |
jswrenn
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes progress on #367, #1634