Rename FromBytes::ref_from[_with_elems] #1278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jswrenn
approved these changes
May 17, 2024
joshlf
force-pushed
the
from-bytes-methods
branch
from
552635b to
a8e4c02
Compare
...to `ref_from_bytes[_with_elems]`. This brings the names in line with the `Ref` methods of the same names, and avoids the awkward name `ref_from_with_elems`. Similarly, rename `Ref::unaligned_from` to `unaligned_from_bytes`. We had already renamed `unaligned_from_with_elems` to `unaligned_from_bytes_with_elems`. Makes progress on #871
joshlf
force-pushed
the
from-bytes-methods
branch
from
a8e4c02 to
8d74855
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1278 +/- ##
==========================================
- Coverage 88.27% 88.22% -0.05%
==========================================
Files 14 14
Lines 5125 5131 +6
==========================================
+ Hits 4524 4527 +3
- Misses 601 604 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...to
ref_from_bytes[_with_elems]. This brings the names in line with theRefmethods of the same names, and avoids the awkward nameref_from_with_elems.Similarly, rename
Ref::unaligned_fromtounaligned_from_bytes. We had already renamedunaligned_from_with_elemstounaligned_from_bytes_with_elems.Makes progress on #871