[ref] Move Ref definition into its own module
#1218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlf
force-pushed
the
ref-module-privacy
branch
3 times, most recently
from
3e8f3c4 to
36159b7
Compare
jswrenn
requested changes
May 8, 2024
This allows us to more strictly enforce the requirement that, for `Ref`'s `ByteSlice` field, methods are never called other than those defined on the `ByteSlice`, `ByteSliceMut`, `IntoByteSlice`, and `IntoByteSliceMut` traits. We accomplish this by keeping the field private, and only exposing unsafe getters which return, for example, `&impl ByteSlice`. We also introduce new traits - `CopyableByteSlice` and `CloneableByteSlice`. We tighten the `Copy` and `Clone` impls for `Ref` to require these bounds. Previously, `ByteSlice` required that its "dereference stability" requirement applied to any `Copy` or `Clone` impls, but this would have prevented us from implementing `ByteSlice` for `Vec`. By splitting the requirement into separate traits, we open the door to supporting `Vec` (#992).
jswrenn
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to more strictly enforce the requirement that, for
Ref'sByteSlicefield, methods are never called other than those defined on theByteSlice,ByteSliceMut,IntoByteSlice, andIntoByteSliceMuttraits. We accomplish this by keeping the field private, and only exposing unsafe getters which return, for example,&impl ByteSlice.We also introduce new traits -
CopyableByteSliceandCloneableByteSlice. We tighten theCopyandCloneimpls forRefto require these bounds. Previously,ByteSlicerequired that its "dereference stability" requirement applied to anyCopyorCloneimpls, but this would have prevented us from implementingByteSliceforVec. By splitting the requirement into separate traits, we open the door to supportingVec(#992).