Skip to content

Allow ports to be defined by users if really needed. https://github.com/google/vizier/issues/1098 #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Allow ports to be defined by users if really needed. https://github.com/google/vizier/issues/1098 #1171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions vizier/_src/service/vizier_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,19 +47,17 @@ class DefaultVizierServer:
(SQL_MEMORY_URL) since tests don't easily allow arbitrarily filepaths.
"""

_host: str = attr.field(init=True, default='localhost')
_database_url: str = attr.field(
init=True, default=constants.SQL_LOCAL_URL, kw_only=True
)
_host: str = attr.field(default='localhost')
_database_url: str = attr.field(default=constants.SQL_LOCAL_URL, kw_only=True)
_policy_factory: pythia.PolicyFactory = attr.field(
init=True,
factory=service_policy_factory_lib.DefaultPolicyFactory,
kw_only=True,
factory=service_policy_factory_lib.DefaultPolicyFactory, kw_only=True
)
_early_stop_recycle_period: datetime.timedelta = attr.field(
init=True, default=datetime.timedelta(seconds=0.1), kw_only=True
default=datetime.timedelta(seconds=0.1), kw_only=True
)
_port: int = attr.field(init=False, factory=portpicker.pick_unused_port)
_port: int = attr.field(factory=portpicker.pick_unused_port, kw_only=True)

# Fields which should not be set by users.
_servicer: vizier_service.VizierServicer = attr.field(init=False)
_server: grpc.Server = attr.field(init=False)
stub: vizier_service_pb2_grpc.VizierServiceStub = attr.field(init=False)
Expand Down Expand Up @@ -106,8 +104,10 @@ class DistributedPythiaVizierServer(DefaultVizierServer):
"""

_pythia_port: int = attr.field(
init=False, factory=portpicker.pick_unused_port
factory=portpicker.pick_unused_port, kw_only=True
)

# Fields which should not be set by users.
_pythia_servicer: pythia_service.PythiaServicer = attr.field(init=False)
_pythia_server: grpc.Server = attr.field(init=False)
pythia_stub: pythia_service_pb2_grpc.PythiaServiceStub = attr.field(
Expand Down
Loading