Skip to content

Conversation

@Gryzor
Copy link

@Gryzor Gryzor commented Aug 25, 2023

Objective

  • Fix the simple out of the box experience when cloning TalkBack and then running "./build.sh" on any recent version of Android Tools/Android Studio.

Description

  • The sdkmanager located in {ANDROID_SDK}"/tools/bin/ contains an old-unmaintained version of the sdk manager that doesn't work with the version of JAVA shipped in modern Android Studio versions.
  • The "new" more updated sdkmanager is located in {ANDROID_SDK}"/cmdline-tools/latest/bin/sdkmanager.
  • It is expected that new Android Devs who have not downloaded this Optional dependency, can do so with one click (and they can, by using the SDK Manager included in their Android Studio. This is better than a cryptic error message like Exception in thread "main" java.lang.NoClassDefFoundError: javax/xml/bind/annotation/XmlSchema when running a build script.

The original location has been deprecated three hundred years ago or more...
@PatrykMis
Copy link

It's unfortunate, but according to this comment TalkBack is not being developed openly and does not [officially - highlight mine] accept pull requests.

For the most current open-source fork of TalkBack, you can check out TalkBack FOSS.

@Gryzor
Copy link
Author

Gryzor commented Aug 25, 2023

It's unfortunate, but according to this comment TalkBack is not being developed openly and does not [officially - highlight mine] accept pull requests.

For the most current open-source fork of TalkBack, you can check out TalkBack FOSS.

Sad.

Thanks for sharing. Closing this PR then. If they'd only include TalkBack in emulators we wouldn't need to compile an APK 😮‍💨

@Gryzor Gryzor closed this Aug 25, 2023
@Gryzor Gryzor deleted the patch_build_sh_so_it_uses_modern_cmdline branch August 25, 2023 15:01
@PatrykMis
Copy link

@Gryzor You're right.

@beqabeqa473
Copy link

beqabeqa473 commented Aug 26, 2023 via email

@PatrykMis
Copy link

PatrykMis commented Aug 26, 2023

@beqabeqa473 you're right, too, at least partially...

User-visible changes as of now:

  • following system theme on Android 12+;
  • improved translations for Polish speaking users

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants