POC: Custom repetitions #39
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayvdb
force-pushed
the
example-sampler
branch
from
d89ce22 to
0b126e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an idea for allowing custom thinning of repeats. It currently replaces
\w\wand similar with three preset values, but the implementation could be a generated set, and could be generically reducing the complete set defined by the regex to be a subset (i.e. sampling/lossy compression).Only the test depends on https://github.com/jayvdb/sre-tools . I am happy to directly contribute a copy of the relevant code here if there is a desire to incorporate this type of functionality. Personally I am happy to call the simplification algorithm before invoking
sre_yield, so I am not pushing for inclusion of that feature. However there are a lot of optimisations that can be done by only merging adjacent identical nodes whilst doing the expansion, because sre_yield is already creating its own internal tree.