Skip to content

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Sep 24, 2020

No description provided.

This was referenced Sep 24, 2020
@thatch
Copy link
Contributor

thatch commented Sep 27, 2020

Tests are passing so I'll go ahead and merge this. This looks like a more complicated version of testing against golden output; we do lose something in readability by the indirection vs just a long string of expected text, and I'm not sure that's made up by the ability to update easily.

@thatch thatch merged commit 3af063a into google:master Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants