-
Notifications
You must be signed in to change notification settings - Fork 245
docs: add example and HTML output screenshot for container scanning #3716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AbhishekHerbertSamuel
wants to merge
6
commits into
google:master
Choose a base branch
from
AbhishekHerbertSamuel:docs/container-scanning
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
dcacc22
docs: add container scan example and HTML output screenshot
AbhishekHerbertSamuel da852cf
docs: add container scan example and HTML output screenshot
AbhishekHerbertSamuel ce8aa36
Website: container scan section at top level; fix /static/img path; r…
AbhishekHerbertSamuel ac0304d
Remove legacy container scan image files
AbhishekHerbertSamuel d70b16a
website: container scan section — match code-card style, align screen…
AbhishekHerbertSamuel 739595f
Merge branch 'master' into docs/container-scanning
AbhishekHerbertSamuel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,6 +21,7 @@ <h1 class="title">A distributed vulnerability database for Open Source</h1> | |
<div class="explainer"> | ||
<p>An open, precise, and distributed approach to producing and consuming vulnerability information for open | ||
source. | ||
</p> | ||
</div> | ||
<div class="cta"> | ||
<a class="cta-primary link-button" href="{{ url_for('frontend_handlers.list_vulnerabilities') }}"> | ||
|
@@ -244,40 +245,46 @@ <h3 class="code-card-title">Guided Remediation (interactive)</h3> | |
<md-icon-button class="icon"><md-icon>content_copy</md-icon></md-icon-button> | ||
</clipboard-copy> | ||
</div> | ||
|
||
|
||
</div> | ||
<div class="mdc-layout-grid__cell--span-12"> | ||
<div class="cta"> | ||
<a class="cta-primary link-button" href="https://google.github.io/osv-scanner/experimental/guided-remediation/">More details</a> | ||
</div> | ||
</div> | ||
</div> | ||
<div id="use-the-github-workflows" class="mdc-layout-grid__cell--span-12 github-action"> | ||
<h2 class="heading">GitHub Workflows</h2> | ||
<div id="use-container-scanning" class="mdc-layout-grid__cell--span-12 usage-examples"> | ||
<h2 class="heading">Container Image Scanning</h2> | ||
<p class="description"> | ||
OSV-Scanner also provides reusable GitHub workflows that can be easily integrated into CI/CD pipelines to provide | ||
continuous vulnerability scanning coverage. This can scan newly added dependencies in pull requests for introduced | ||
vulnerabilities, as well as perform regular vulnerability scans for the entire project.</p> | ||
<div class="image-container"> | ||
<img src="/static/img/github-action-scan-output.webp" alt="Screenshot of OSV-Scanner GitHub Action" loading="lazy"> | ||
</div> | ||
<div class="cta"> | ||
<a class="cta-primary link-button" href="https://google.github.io/osv-scanner/github-action/" | ||
aria-label="Learn more about osv scanner github action">Learn more</a> | ||
</div> | ||
</div> | ||
<div class="mdc-layout-grid__cell--span-12 open-source-banner"> | ||
<h2 class="heading">Open source</h2> | ||
<p class="description"> | ||
This project is <a href="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/google/osv">open source</a>. If you have any ideas or questions, | ||
please feel free to | ||
reach out by <a href="https://github.com/google/osv/issues/new/choose">creating an issue</a>! | ||
You can use <a href="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/google/osv-scanner" target="_blank" rel="noopener">OSV-Scanner</a> | ||
to scan your container images for known vulnerabilities. | ||
</p> | ||
<div class="cta"> | ||
<a class="cta-primary link-button" href="https://google.github.io/osv.dev/faq/" | ||
aria-label="Learn more on our FAQ">Learn more</a> | ||
|
||
<!-- Command box (same look as 'Use the API' cards, centered) --> | ||
<div class="code-card-container mdc-layout-grid__inner"> | ||
<div class="mobile-spacer mdc-layout-grid__cell--span-3"></div> | ||
<div class="code-card mdc-layout-grid__cell--span-6 mdc-layout-grid__cell--span-12-tablet"> | ||
<h3 class="code-card-title">Scan container image</h3> | ||
<pre class="code-card-content" id="example-container-scan-serve">osv-scanner scan image --serve alpine:3.12</pre> | ||
<clipboard-copy class="code-card-copy" for="example-container-scan-serve"> | ||
<md-icon-button class="icon"><md-icon>content_copy</md-icon></md-icon-button> | ||
</clipboard-copy> | ||
</div> | ||
<div class="mobile-spacer mdc-layout-grid__cell--span-3"></div> | ||
</div> | ||
|
||
<!-- Big screenshot (same size/markup as GitHub Workflows) --> | ||
<div class="mdc-layout-grid__inner" style="margin-top: 16px;"> | ||
<div class="mdc-layout-grid__cell--span-12"> | ||
<div class="container-scan-image"> | ||
<img | ||
src="/static/img/container-scan-html.png" | ||
alt="Screenshot of container scan HTML output" | ||
loading="lazy"> | ||
</div> | ||
</div> | ||
</div> | ||
</div> | ||
</div> | ||
<footer></footer> | ||
</div> | ||
{% endblock %} | ||
|
||
<div id="use-the-github-workflows" class="mdc-layout-grid__cell--span-12 github-action"> <h2 class="heading">GitHub Workflows</h2> <p class="description"> OSV-Scanner also provides reusable GitHub workflows that can be easily integrated into CI/CD pipelines to provide continuous vulnerability scanning coverage. This can scan newly added dependencies in pull requests for introduced vulnerabilities, as well as perform regular vulnerability scans for the entire project.</p> <div class="image-container"> <img src="/static/img/github-action-scan-output.webp" alt="Screenshot of OSV-Scanner GitHub Action" loading="lazy"> </div> <div class="cta"> <a class="cta-primary link-button" href="https://google.github.io/osv-scanner/github-action/" aria-label="Learn more about osv scanner github action">Learn more</a> </div> </div> <div class="mdc-layout-grid__cell--span-12 open-source-banner"> <h2 class="heading">Open source</h2> <p class="description"> This project is <a href="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/google/osv">open source</a>. If you have any ideas or questions, please feel free to reach out by <a href="https://github.com/google/osv/issues/new/choose">creating an issue</a>! </p> <div class="cta"> <a class="cta-primary link-button" href="https://google.github.io/osv.dev/faq/" aria-label="Learn more on our FAQ">Learn more</a> </div> </div> </div> <footer></footer> </div> {% endblock %} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This seems to be misformatted? Everything is on one line? |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The image is still far too big, it needs a max width of ~1000px or so to look right.
Also, the image seems to have a very noticible black top border, maybe it needs to be cropped by a few pixels at the top.