In Strings.lenientFormat, don't assign into the varargs array.
#7955
+18
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_799574193
branch
from
93571bb to
a535b6e
Compare
When the method is called with an actual array argument, rather than as varargs, assigning into that array is at best surprising. It may also cause an `ArrayStoreException` if the component type of the array is not compatible with `String`. RELNOTES=`Strings.lenientFormat` no longer assigns into its varargs array argument. PiperOrigin-RevId: 800096793
copybara-service
bot
force-pushed
the
test_799574193
branch
from
a535b6e to
148cea0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
Strings.lenientFormat, don't assign into the varargs array.When the method is called with an actual array argument, rather than as varargs, assigning into that array is at best surprising. It may also cause an
ArrayStoreExceptionif the component type of the array is not compatible withString.RELNOTES=
Strings.lenientFormatno longer assigns into its varargs array argument.