fix: exclude section is not necessary #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsconfig.json doesn't need an exclude section when an include section is present. Fixes: google#70
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
=======================================
Coverage 96.66% 96.66%
=======================================
Files 10 10
Lines 330 330
Branches 19 19
=======================================
Hits 319 319
Misses 11 11Continue to review full report at Codecov.
|
jinwoo
approved these changes
Apr 3, 2018
| @@ -155,8 +155,7 @@ async function generateTsConfig(options: Options): Promise<void> { | |||
| const tsconfig = formatJson({ | |||
| extends: './node_modules/gts/tsconfig-google.json', | |||
| compilerOptions: {rootDir: '.', outDir: 'build'}, | |||
| include: ['src/*.ts', 'src/**/*.ts', 'test/*.ts', 'test/**/*.ts'], | |||
| exclude: ['node_modules'] | |||
There was a problem hiding this comment.
I had to exclude node_modules in one of my projects sometime in the past, but I forgot why.
| @@ -155,8 +155,7 @@ async function generateTsConfig(options: Options): Promise<void> { | |||
| const tsconfig = formatJson({ | |||
| extends: './node_modules/gts/tsconfig-google.json', | |||
| compilerOptions: {rootDir: '.', outDir: 'build'}, | |||
| include: ['src/*.ts', 'src/**/*.ts', 'test/*.ts', 'test/**/*.ts'], | |||
| exclude: ['node_modules'] | |||
| include: ['src/*.ts', 'src/**/*.ts', 'test/*.ts', 'test/**/*.ts'] | |||
There was a problem hiding this comment.
Side note. We say main: index.js when we say our source files are in these directories... well...
There was a problem hiding this comment.
That's because we generate the package.json using npm defaults hence:
We should refine this to better match the expected project layout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tsconfig.json doesn't need an exclude section when an include section
is present.
Fixes: #70