Skip to content

chore: integrate NPM publish with CircleCI #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2018
Merged

Conversation

jinwoo
Copy link
Member

@jinwoo jinwoo commented Mar 2, 2018

Also run docker as non-root user.

Also run docker as non-root user.
@jinwoo jinwoo requested review from ofrobots and a team March 2, 2018 23:25
@codecov-io
Copy link

codecov-io commented Mar 2, 2018

Codecov Report

Merging #130 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #130   +/-   ##
=======================================
  Coverage   96.64%   96.64%           
=======================================
  Files          10       10           
  Lines         328      328           
  Branches       19       19           
=======================================
  Hits          317      317           
  Misses         11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fd094b...183a2fc. Read the comment docs.

@jinwoo jinwoo merged commit 1d4265c into google:master Mar 3, 2018
@jinwoo jinwoo deleted the circleci branch March 3, 2018 01:07
@jinwoo
Copy link
Member Author

jinwoo commented Mar 3, 2018

We need one more thing to enable NPM auto-publish. The NPM_TOKEN env var must be set in the CircleCI config. @ofrobots Can you please do that? I don't think I can.

@ofrobots
Copy link
Contributor

ofrobots commented Mar 3, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants