chore: lint self #10
Merged
chore: lint self #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinBeckwith
requested changes
Aug 3, 2017
| "format": "clang-format -i -style='{Language: JavaScript, BasedOnStyle: Google, ColumnLimit: 80}' src/*.ts", | ||
| "lint": "tslint -c tslint.json --project . --type-check -t codeFrame", | ||
| "lint-fix": "tslint -c tslint.json --project . --type-check -t codeFrame --fix", | ||
| "release": "standard-version", | ||
| "test": "echo \"Error: no test specified\" && exit 1" | ||
| "test": "echo \"TODO\"", | ||
| "posttest": "npm run lint && npm run format-check" |
There was a problem hiding this comment.
I think I'd rather have linting pretest?
There was a problem hiding this comment.
For me, in an edit-build-test development cycle I care about lint and format as the very last step once my feature is complete (i.e. I've gotten all the tests to pass).
I find it annouying to be told that my code isn't formatted correctly when I am just trying to see if this is 'functionally correct' w.r.t. tests.
| @@ -22,11 +22,13 @@ | |||
| "build": "npm run compile", | |||
| "clean": "rm -rf ./build/", | |||
| "compile": "tsc -p . --rootDir . --outDir build/", | |||
| "format-check": "echo \"TODO\"", | |||
There was a problem hiding this comment.
Do we really need a format check? Or should we just go ahead and auto-format on build?
There was a problem hiding this comment.
This can be dangerous if the user has unsaved edits in their editor. A 'test' job should not make edits IMO.
JustinBeckwith
approved these changes
Aug 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.