Remove GsonPreconditions#checkNotNull
#2878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method is not used within the Gson code and was only kept for backward compatibility in case external projects used it. However, 45e5e14 renamed the enclosing class, which already broke backward compatibility. Therefore it should be safe to remove the method now.
eamonnmcmanus
approved these changes
Jul 15, 2025
There was a problem hiding this comment.
Thanks!
I also wonder if we could just get rid of the GsonPreconditions class altogether. In each of the 9 places that use checkArgument, we could either have an explicit if+throw or a class-local checkArgument implementation. Otherwise I'm afraid we're going to end up with people referencing this class again, despite the internal in its name.
|
Have created #2879 to remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method is not used within the Gson code and was only kept for backward compatibility in case external projects used it, see #2180 (comment).
However, #2838 renamed the enclosing class, which already broke backward compatibility. Therefore it should be safe to remove the method now.