-
Notifications
You must be signed in to change notification settings - Fork 4.4k
refactor: replace local StringWriter with StringBuilder #2852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace local StringWriter with StringBuilder #2852
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
bafd589
to
4ce8f1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks excellent!
…ip ci] Bumps [com.google.code.gson:gson](https://github.com/google/gson) from 2.13.1 to 2.13.2. Release notes *Sourced from [com.google.code.gson:gson's releases](https://github.com/google/gson/releases).* > Gson 2.13.2 > ----------- > > The main changes in this release are just newer dependencies. > > What's Changed > -------------- > > * Improved packaging of JPMS module declaration in Gson jar > This fixes an issue where Eclipse and VS Code users could not refer to the Gson module name `com.google.gson`. See issue [google/gson#2679](https://redirect.github.com/google/gson/issues/2679). > * Remove internal class `GsonPreconditions` by [`@Marcono1234`](https://github.com/Marcono1234) in [google/gson#2879](https://redirect.github.com/google/gson/pull/2879) > * Switch to using central-publishing-maven-plugin by [`@eamonnmcmanus`](https://github.com/eamonnmcmanus) in [google/gson#2900](https://redirect.github.com/google/gson/pull/2900) > > New Contributors > ---------------- > > * [`@MukjepScarlet`](https://github.com/MukjepScarlet) made their first contribution in [google/gson#2852](https://redirect.github.com/google/gson/pull/2852) > * [`@ChrisCraik`](https://github.com/ChrisCraik) made their first contribution in [google/gson#2856](https://redirect.github.com/google/gson/pull/2856) > > **Full Changelog**: <google/gson@gson-parent-2.13.1...gson-parent-2.13.2> Commits * [`686fad7`](google/gson@686fad7) [maven-release-plugin] prepare release gson-parent-2.13.2 * [`c2d252a`](google/gson@c2d252a) Switch to using central-publishing-maven-plugin. ([#2900](https://redirect.github.com/google/gson/issues/2900)) * [`69cb755`](google/gson@69cb755) Bump the github-actions group with 5 updates ([#2894](https://redirect.github.com/google/gson/issues/2894)) * [`ea552c2`](google/gson@ea552c2) Bump the maven group across 1 directory with 3 updates ([#2898](https://redirect.github.com/google/gson/issues/2898)) * [`fdc616d`](google/gson@fdc616d) Set top-level permissions for CodeQL workflow ([#2889](https://redirect.github.com/google/gson/issues/2889)) * [`9334715`](google/gson@9334715) Create scorecard.yml ([#2888](https://redirect.github.com/google/gson/issues/2888)) * [`f7de5c2`](google/gson@f7de5c2) Bump the maven group with 8 updates ([#2885](https://redirect.github.com/google/gson/issues/2885)) * [`8c23cd3`](google/gson@8c23cd3) Update sources to satisfy a new Error Prone check. ([#2887](https://redirect.github.com/google/gson/issues/2887)) * [`5eab3ed`](google/gson@5eab3ed) Bump the github-actions group with 2 updates ([#2886](https://redirect.github.com/google/gson/issues/2886)) * [`5f5c200`](google/gson@5f5c200) Bump the maven group across 1 directory with 10 updates ([#2872](https://redirect.github.com/google/gson/issues/2872)) * Additional commits viewable in [compare view](google/gson@gson-parent-2.13.1...gson-parent-2.13.2) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
StringWriter
usesStringBuffer
in it. It's widely known that StringBuffer has extra sync operations for local usages. This change can slightly improve performance.Related: #2645