Skip to content

Refactor if-else chains to switch in benchmark methods #2756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2024
+30 −20
Merged

Refactor if-else chains to switch in benchmark methods #2756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions metrics/src/main/java/com/google/gson/metrics/BagOfPrimitivesDeserializationBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,16 +64,21 @@ public void timeBagOfPrimitivesStreaming(int reps) throws IOException {
String stringValue = null;
while (jr.hasNext()) {
String name = jr.nextName();
if (name.equals("longValue")) {
longValue = jr.nextLong();
} else if (name.equals("intValue")) {
intValue = jr.nextInt();
} else if (name.equals("booleanValue")) {
booleanValue = jr.nextBoolean();
} else if (name.equals("stringValue")) {
stringValue = jr.nextString();
} else {
throw new IOException("Unexpected name: " + name);
switch (name) {
case "longValue":
longValue = jr.nextLong();
break;
case "intValue":
intValue = jr.nextInt();
break;
case "booleanValue":
booleanValue = jr.nextBoolean();
break;
case "stringValue":
stringValue = jr.nextString();
break;
default:
throw new IOException("Unexpected name: " + name);
}
}
jr.endObject();
Expand Down
25 changes: 15 additions & 10 deletions metrics/src/main/java/com/google/gson/metrics/CollectionsDeserializationBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,16 +76,21 @@ public void timeCollectionsStreaming(int reps) throws IOException {
String stringValue = null;
while (jr.hasNext()) {
String name = jr.nextName();
if (name.equals("longValue")) {
longValue = jr.nextLong();
} else if (name.equals("intValue")) {
intValue = jr.nextInt();
} else if (name.equals("booleanValue")) {
booleanValue = jr.nextBoolean();
} else if (name.equals("stringValue")) {
stringValue = jr.nextString();
} else {
throw new IOException("Unexpected name: " + name);
switch (name) {
case "longValue":
longValue = jr.nextLong();
break;
case "intValue":
intValue = jr.nextInt();
break;
case "booleanValue":
booleanValue = jr.nextBoolean();
break;
case "stringValue":
stringValue = jr.nextString();
break;
default:
throw new IOException("Unexpected name: " + name);
}
}
jr.endObject();
Expand Down