Fix graal-native-image-test module causing failure for 'Check API compatibility' #2467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…patibility' The 'Check API compatibility' workflow runs `mvn install` to install the previous version to the local Maven repository to compare it afterwards. However this fails for the graal-native-image-test module because it does not produce a JAR. Therefore skip execution of the maven-install-plugin for that module.
eamonnmcmanus
approved these changes
Aug 13, 2023
tibor-universe
pushed a commit
to getuniverse/gson
that referenced
this pull request
Sep 14, 2024
…patibility' (google#2467) The 'Check API compatibility' workflow runs `mvn install` to install the previous version to the local Maven repository to compare it afterwards. However this fails for the graal-native-image-test module because it does not produce a JAR. Therefore skip execution of the maven-install-plugin for that module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Follow-up for #2466
Description
The 'Check API compatibility' workflow runs
mvn installto install the previous version in the local Maven repository to compare it afterwards. However this fails for the graal-native-image-test module because it does not produce a JAR.Therefore now skip execution of the maven-install-plugin for that module. I hope no further issues (e.g. on release) occur due to the graal-native-image-test module having no JAR file.
Unfortunately I overlooked that for my previous PR.
The 'Check API compatibility' failure for this PR here is 'expected' and is exactly what this PR tries to fix. But because the 'Check API compatibility' workflow runs
mvn installfor the target branch of a PR, it still fails for this PR, but should work fine again for any subsequent ones.